diff options
author | dol-sen <brian.dolbec@gmail.com> | 2011-07-12 12:57:08 -0700 |
---|---|---|
committer | dol-sen <brian.dolbec@gmail.com> | 2011-07-12 12:57:08 -0700 |
commit | 021d8bc9211cb4f4adad814f6c1bbcd399f72786 (patch) | |
tree | a6eae9ac8f15f139acb64ad498eb728c7d334009 | |
parent | 76fb866e094ebefb2ba57f230d5e26f96346e3d4 (diff) | |
download | layman-021d8bc9211cb4f4adad814f6c1bbcd399f72786.tar.gz layman-021d8bc9211cb4f4adad814f6c1bbcd399f72786.tar.bz2 layman-021d8bc9211cb4f4adad814f6c1bbcd399f72786.zip |
fix success mistracking
-rw-r--r-- | layman/api.py | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/layman/api.py b/layman/api.py index 8e54d7d..985eee0 100644 --- a/layman/api.py +++ b/layman/api.py @@ -114,14 +114,15 @@ class LaymanAPI(object): self._error("Repository '"+ovl+"' was not installed") results.append(False) continue + success = False try: self._get_installed_db().delete( self._get_installed_db().select(ovl)) - results.append(True) except Exception as e: self._error( - "Failed to disable repository '"+ovl+"':\n"+str(e)) - results.append(False) + "Exception caught disabling repository '"+ovl+ + "':\n"+str(e)) + results.append(success) self.get_installed(dbreload=True) if False in results: return False @@ -147,12 +148,14 @@ class LaymanAPI(object): self._error(UnknownOverlayMessage(ovl)) results.append(False) continue + success = False try: - self._get_installed_db().add(self._get_remote_db().select(ovl), quiet=True) - results.append(True) + success = self._get_installed_db().add( + self._get_remote_db().select(ovl), quiet=True) except Exception as e: - self._error("Failed to enable repository '"+ovl+"' : "+str(e)) - results.append(False) + self._error("Exception caught enabling repository '"+ovl+ + "' : "+str(e)) + results.append(success) self.get_installed(dbreload=True) if False in results: return False |