summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2011-08-08 23:44:17 -0700
committerZac Medico <zmedico@gentoo.org>2011-08-08 23:44:17 -0700
commit022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2 (patch)
tree02d9c90b1a135b384b9db9a04acde146a0e5845b
parent596258fb36afbf6996e182c18aa35dc8803d07cd (diff)
downloadportage-022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2.tar.gz
portage-022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2.tar.bz2
portage-022e09dd6ddd8372a9ec2ef2284b7cb174e6e6b2.zip
repoman: check more helper calls for $D, $ED...
This adds docinto, docompress, fowners and fperms to the variable.usedwithhelpers check. Notably absent is dosed since that supports mixed input. This will fix bug #377303.
-rw-r--r--pym/repoman/checks.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index e7472df72..bff4b1fbf 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -341,7 +341,7 @@ class NoOffsetWithHelpers(LineCheck):
repoman_check_name = 'variable.usedwithhelpers'
# Ignore matches in quoted strings like this:
# elog "installed into ${ROOT}usr/share/php5/apc/."
- re = re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
+ re = re.compile(r'^[^#"\']*\b(docinto|docompress|dodir|dohard|exeinto|fowners|fperms|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
error = errors.NO_OFFSET_WITH_HELPERS
class ImplicitRuntimeDeps(LineCheck):