diff options
| author | Zac Medico <zmedico@gentoo.org> | 2009-10-01 19:29:24 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2009-10-01 19:29:24 +0000 |
| commit | 152cd1ff317038b9832dcfaff1d9844d02eabc35 (patch) | |
| tree | 4e7238004748acb300e689962df1d7712d5a43e6 | |
| parent | cfe0aba4bc70f88b406dc82f7962d4e9778b2117 (diff) | |
| download | portage-152cd1ff317038b9832dcfaff1d9844d02eabc35.tar.gz portage-152cd1ff317038b9832dcfaff1d9844d02eabc35.tar.bz2 portage-152cd1ff317038b9832dcfaff1d9844d02eabc35.zip | |
Bug #285191 - Remove the RDEPEND.implicit check because it is invalid.
svn path=/main/trunk/; revision=14471
| -rw-r--r-- | man/repoman.1 | 4 | ||||
| -rw-r--r-- | pym/repoman/checks.py | 33 |
2 files changed, 1 insertions, 36 deletions
diff --git a/man/repoman.1 b/man/repoman.1 index 52ef02a1e..b07427749 100644 --- a/man/repoman.1 +++ b/man/repoman.1 @@ -186,10 +186,6 @@ Masked ebuilds with RDEPEND settings (matched against *all* ebuilds) .B RDEPEND.badmaskedindev Masked ebuilds with RDEPEND settings (matched against *all* ebuilds) in developing arch .TP -.B RDEPEND.implicit -RDEPEND is unset in the ebuild which triggers implicit RDEPEND=$DEPEND -assignment -.TP .B RDEPEND.suspect RDEPEND contains a package that usually only belongs in DEPEND .TP diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index bfb262545..5058ec77e 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -268,37 +268,6 @@ class EbuildQuotedA(LineCheck): if match: return "Quoted \"${A}\" on line: %d" -class ImplicitRuntimeDeps(LineCheck): - """ - Detect the case where DEPEND is set and RDEPEND is unset in the ebuild, - since this triggers implicit RDEPEND=$DEPEND assignment. - """ - - _assignment_re = re.compile(r'^\s*(R?DEPEND)=') - - def new(self, pkg): - # RDEPEND=DEPEND is no longer available in EAPI=3 - if pkg.metadata['EAPI'] in ('0', '1', '2'): - self.repoman_check_name = 'RDEPEND.implicit' - else: - self.repoman_check_name = 'EAPI.incompatible' - self._rdepend = False - self._depend = False - - def check(self, num, line): - if not self._rdepend: - m = self._assignment_re.match(line) - if m is None: - pass - elif m.group(1) == "RDEPEND": - self._rdepend = True - elif m.group(1) == "DEPEND": - self._depend = True - - def end(self): - if self._depend and not self._rdepend: - yield 'RDEPEND is not explicitly assigned' - class InheritAutotools(LineCheck): """ Make sure appropriate functions are called in @@ -493,7 +462,7 @@ _constant_checks = tuple((c() for c in ( EbuildAssignment, EbuildUselessDodoc, EbuildUselessCdS, EbuildNestedDie, EbuildPatches, EbuildQuotedA, EapiDefinition, - IUseUndefined, ImplicitRuntimeDeps, InheritAutotools, + IUseUndefined, InheritAutotools, EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue, SrcCompileEconf, Eapi3IncompatibleFuncs, Eapi3GoneVars))) |