summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichał Górny <gentoo@mgorny.alt.pl>2010-08-26 18:38:52 +0200
committerZac Medico <zmedico@gentoo.org>2010-08-26 09:46:19 -0700
commitb0b3fdd9b572d9341e0456c7e1e241c795929224 (patch)
tree4f0d2f6976720ae1e20315f2a6cb26e9eff91a0c
parent6d9615ea11988c45e4b7c47f40b0439b1ecefec8 (diff)
downloadportage-b0b3fdd9b572d9341e0456c7e1e241c795929224.tar.gz
portage-b0b3fdd9b572d9341e0456c7e1e241c795929224.tar.bz2
portage-b0b3fdd9b572d9341e0456c7e1e241c795929224.zip
Disable 'unused local USE-description' check if there are any invalids.
If any of the ebuilds is considered invalid, the used_useflags list may not be complete. Thus, performing the test could cause a lot of useless noise.
-rwxr-xr-xbin/repoman14
1 files changed, 9 insertions, 5 deletions
diff --git a/bin/repoman b/bin/repoman
index 5c01c3696..86b4c1c46 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -1394,6 +1394,7 @@ for x in scanlist:
changelog_path = os.path.join(checkdir_relative, "ChangeLog")
changelog_modified = changelog_path in modified_changelogs
+ allvalid = True
allmasked = True
# detect unused local USE-descriptions
used_useflags = set()
@@ -1432,6 +1433,7 @@ for x in scanlist:
pkg = pkgs[y]
if pkg.invalid:
+ allvalid = False
for k, msgs in pkg.invalid.items():
for msg in msgs:
stats[k] = stats[k] + 1
@@ -1927,11 +1929,13 @@ for x in scanlist:
fails["ebuild.allmasked"].append(x)
# check if there are unused local USE-descriptions in metadata.xml
- for myflag in muselist.difference(used_useflags):
- stats["metadata.warning"] += 1
- fails["metadata.warning"].append(
- "%s/metadata.xml: unused local USE-description: '%s'" % \
- (x, myflag))
+ # (unless there are any invalids, to avoid noise)
+ if allvalid:
+ for myflag in muselist.difference(used_useflags):
+ stats["metadata.warning"] += 1
+ fails["metadata.warning"].append(
+ "%s/metadata.xml: unused local USE-description: '%s'" % \
+ (x, myflag))
if options.mode == "manifest":
sys.exit(dofail)