summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2009-06-28 18:24:23 +0000
committerZac Medico <zmedico@gentoo.org>2009-06-28 18:24:23 +0000
commit0db2a617938c50900e75cf52c767c3acf6647b76 (patch)
tree808576240db6a2bfa005aa62e5bddb68bfc821ae
parent06a37a97b6963b0ee68740bac08501dc467801da (diff)
downloadportage-0db2a617938c50900e75cf52c767c3acf6647b76.tar.gz
portage-0db2a617938c50900e75cf52c767c3acf6647b76.tar.bz2
portage-0db2a617938c50900e75cf52c767c3acf6647b76.zip
Bug #236786 - Warn about 'test?' USE conditionals in RDEPEND. Thanks to
Markus Meier <maekke@gentoo.org> for this patch. svn path=/main/trunk/; revision=13724
-rwxr-xr-xbin/repoman6
1 files changed, 5 insertions, 1 deletions
diff --git a/bin/repoman b/bin/repoman
index 41c811039..09b79da23 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -1404,7 +1404,11 @@ for x in scanlist:
if mytype in ("DEPEND", "RDEPEND", "PDEPEND"):
for token in mydepstr.split():
if token in operator_tokens or \
- token.endswith("?"):
+ token[-1:] == "?":
+ if token == "test?" and mytype == "RDEPEND":
+ stats['RDEPEND.suspect'] += 1
+ fails['RDEPEND.suspect'].append(relative_path + \
+ ": 'test?' USE conditional in RDEPEND")
continue
try:
atom = portage.dep.Atom(token)