diff options
| author | Zac Medico <zmedico@gentoo.org> | 2008-04-28 01:30:49 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2008-04-28 01:30:49 +0000 |
| commit | b908c181406cb538f3fb270e5bf996073ee13375 (patch) | |
| tree | 5c51ed991db8cd9d2f504ef960358be7ac7ccd9c | |
| parent | 325ab57a9fa754ac8cf6c4acea05e108d455cd3b (diff) | |
| download | portage-b908c181406cb538f3fb270e5bf996073ee13375.tar.gz portage-b908c181406cb538f3fb270e5bf996073ee13375.tar.bz2 portage-b908c181406cb538f3fb270e5bf996073ee13375.zip | |
Fix the EbuildQuote check to ignore "echo" and the elog functions since
people might not want quotes in those cases. (trunk r10006)
svn path=/main/branches/2.1.2/; revision=10011
| -rwxr-xr-x | bin/repoman | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/bin/repoman b/bin/repoman index 5720bf112..5cf54d6d5 100755 --- a/bin/repoman +++ b/bin/repoman @@ -955,7 +955,10 @@ class EbuildQuote(LineCheck): """Ensure ebuilds have valid quoting around things like D,FILESDIR, etc...""" repoman_check_name = 'ebuild.minorsyn' - ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)|(^\s*(local|export)\s+)') + _ignored_commands = ["echo", "local", "export"] + _ignored_commands += ["eerror", "einfo", "elog", "eqawarn", "ewarn"] + ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)' + \ + r'|(^\s*(' + "|".join(_ignored_commands) + r')\s+)') var_names = ["D", "DISTDIR", "FILESDIR", "S", "T", "ROOT", "WORKDIR"] # variables for games.eclass |