diff options
| author | Zac Medico <zmedico@gentoo.org> | 2009-12-24 04:01:50 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2009-12-24 04:01:50 +0000 |
| commit | 601d518d636319f367280a6ed008cd974a18f884 (patch) | |
| tree | 779c127094d034b087276c70a4b900621d5f1163 | |
| parent | 07a5b917623a0ce43ef9b4f2d0ef8387c56058cd (diff) | |
| download | portage-601d518d636319f367280a6ed008cd974a18f884.tar.gz portage-601d518d636319f367280a6ed008cd974a18f884.tar.bz2 portage-601d518d636319f367280a6ed008cd974a18f884.zip | |
Bug #297541 - Make $(no-as-needed) trigger upstream.workaround warning. Thanks
to Samuli Suominen <ssuominen@g.o> for this patch. (trunk r15128)
svn path=/main/branches/2.1.7/; revision=15140
| -rw-r--r-- | pym/repoman/checks.py | 8 | ||||
| -rw-r--r-- | pym/repoman/errors.py | 1 |
2 files changed, 8 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 3156894f6..4e83e6653 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -374,6 +374,12 @@ class EMakeParallelDisabledViaMAKEOPTS(LineCheck): re = re.compile(r'^\s*MAKEOPTS=(\'|")?.*-j\s*1\b') error = errors.EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS +class NoAsNeeded(LineCheck): + """Check for calls to the no-as-needed function.""" + repoman_check_name = 'upstream.workaround' + re = re.compile(r'.*\$\(no-as-needed\)') + error = errors.NO_AS_NEEDED + class DeprecatedBindnowFlags(LineCheck): """Check for calls to the deprecated bindnow-flags function.""" repoman_check_name = 'ebuild.minorsyn' @@ -468,7 +474,7 @@ _constant_checks = tuple((c() for c in ( EbuildUselessCdS, EbuildNestedDie, EbuildPatches, EbuildQuotedA, EapiDefinition, IUseUndefined, InheritAutotools, - EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, + EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded, DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue, SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars))) diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py index bab2faca7..b62af12b3 100644 --- a/pym/repoman/errors.py +++ b/pym/repoman/errors.py @@ -17,3 +17,4 @@ EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEOPTS=-j1 on line: %d)' DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d' EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d' +NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)' |