summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2007-10-10 08:07:00 +0000
committerZac Medico <zmedico@gentoo.org>2007-10-10 08:07:00 +0000
commit540715f6f86b6bb6d39697222565bea7d3939291 (patch)
tree7e7f3b08dd55abdb2c668177059bacc74a68840a
parent6200593c44a177f93a2e677589648c4f9cf3f40e (diff)
downloadportage-540715f6f86b6bb6d39697222565bea7d3939291.tar.gz
portage-540715f6f86b6bb6d39697222565bea7d3939291.tar.bz2
portage-540715f6f86b6bb6d39697222565bea7d3939291.zip
Comment about avoiding expensive metadata pulls
in depgraph.select_dep(). svn path=/main/trunk/; revision=8038
-rw-r--r--pym/emerge/__init__.py6
1 files changed, 6 insertions, 0 deletions
diff --git a/pym/emerge/__init__.py b/pym/emerge/__init__.py
index 7f4159ea9..123e8683c 100644
--- a/pym/emerge/__init__.py
+++ b/pym/emerge/__init__.py
@@ -2065,6 +2065,12 @@ class depgraph(object):
old_use, iuses,
now_use, cur_iuse):
break
+ # Metadata accessed above is cached internally by
+ # each db in order to optimize visibility checks.
+ # Now that all possible checks visibility checks
+ # are complete, it's time to pull the rest of the
+ # metadata (including *DEPEND). This part is more
+ # expensive, so avoid it whenever possible.
metadata.update(izip(self._mydbapi_keys,
db.aux_get(cpv, self._mydbapi_keys)))
if not built: