summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2010-10-03 00:57:35 -0700
committerZac Medico <zmedico@gentoo.org>2010-10-06 15:50:02 -0700
commit0fa7de4f5c601c4682266b937df260f2199e05ec (patch)
treea48b11f747c7618a62a46e68ccd1eb7357eed381
parent30449b96a7b4e7a709858923c479b9aff6968fa7 (diff)
downloadportage-0fa7de4f5c601c4682266b937df260f2199e05ec.tar.gz
portage-0fa7de4f5c601c4682266b937df260f2199e05ec.tar.bz2
portage-0fa7de4f5c601c4682266b937df260f2199e05ec.zip
TODO: Make elog 'key' parameter more unique.
-rw-r--r--pym/portage/elog/messages.py9
1 files changed, 9 insertions, 0 deletions
diff --git a/pym/portage/elog/messages.py b/pym/portage/elog/messages.py
index 6b4561fe7..9a0e510fb 100644
--- a/pym/portage/elog/messages.py
+++ b/pym/portage/elog/messages.py
@@ -82,6 +82,15 @@ def _elog_base(level, msg, phase="other", key=None, color=None, out=None):
directly.
"""
+ # TODO: Have callers pass in a more unique 'key' parameter than a plain
+ # cpv, in order to ensure that messages are properly grouped together
+ # for a given package instance, and also to ensure that each elog module's
+ # process() function is only called once for each unique package. This is
+ # needed not only when building packages in parallel, but also to preserve
+ # continuity in messages when a package is simply updated, since we don't
+ # want the elog_process() call from the uninstall of the old version to
+ # cause discontinuity in the elog messages of the new one being installed.
+
global _msgbuffer
if out is None: