diff options
| author | Zac Medico <zmedico@gentoo.org> | 2007-11-10 17:31:08 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2007-11-10 17:31:08 +0000 |
| commit | 5a99498c199dc8246082af6386e943d7920b020e (patch) | |
| tree | 2117b3b1929243657551d50ecb71028583c73399 | |
| parent | 8379acb08643acb9c4e372911219fd3e9ae86e2a (diff) | |
| download | portage-5a99498c199dc8246082af6386e943d7920b020e.tar.gz portage-5a99498c199dc8246082af6386e943d7920b020e.tar.bz2 portage-5a99498c199dc8246082af6386e943d7920b020e.zip | |
Make the EbuildQuote.missing_quotes regex accept single
quotes where it accepts double quotes in order to
eliminate some false positives. Thanks to Krzysiek
Pawlik <nelchael@gentoo.org> for reporting.
svn path=/main/trunk/; revision=8485
| -rw-r--r-- | pym/repoman/checks.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 63a097501..916003e7e 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -78,8 +78,8 @@ class EbuildQuote(LineCheck): var_names = r'(D|S|T|ROOT|FILESDIR|WORKDIR)' var_reference = re.compile(r'\$(\{'+var_names+'\}|' + \ var_names + '\W)') - missing_quotes = re.compile(r'(\s|^)[^"\s]*\$\{?' + var_names + \ - r'\}?[^"\s]*(\s|$)') + missing_quotes = re.compile(r'(\s|^)[^"\'\s]*\$\{?' + var_names + \ + r'\}?[^"\'\s]*(\s|$)') cond_begin = re.compile(r'(^|\s+)\[\[($|\\$|\s+)') cond_end = re.compile(r'(^|\s+)\]\]($|\\$|\s+)') |