diff options
| author | Zac Medico <zmedico@gentoo.org> | 2010-08-17 07:38:13 -0700 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2010-08-17 07:38:13 -0700 |
| commit | 080bd63355b3a73bce92a7bf23c51e192209bd48 (patch) | |
| tree | d699b6c8e0eac98900ba2af931929e409fc8c6bb | |
| parent | e48d76874acf68de724161639519f5aaef7d2b72 (diff) | |
| download | portage-080bd63355b3a73bce92a7bf23c51e192209bd48.tar.gz portage-080bd63355b3a73bce92a7bf23c51e192209bd48.tar.bz2 portage-080bd63355b3a73bce92a7bf23c51e192209bd48.zip | |
Tweak the EbuildSpawnProcess test and add comments.
| -rw-r--r-- | pym/portage/tests/ebuild/test_doebuild_spawn.py | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/pym/portage/tests/ebuild/test_doebuild_spawn.py b/pym/portage/tests/ebuild/test_doebuild_spawn.py index 32123e279..c8a8095d3 100644 --- a/pym/portage/tests/ebuild/test_doebuild_spawn.py +++ b/pym/portage/tests/ebuild/test_doebuild_spawn.py @@ -19,7 +19,7 @@ class DoebuildSpawnTestCase(TestCase): Invoke portage.package.ebuild.doebuild.spawn() with a minimal environment. This gives coverage to some of the ebuild execution internals, like ebuild.sh, - EbuildSpawnProcess, and EbuildIpcDaemon. + AbstractEbuildProcess, and EbuildIpcDaemon. """ def testDoebuildSpawn(self): @@ -54,8 +54,14 @@ class DoebuildSpawnTestCase(TestCase): task_scheduler = TaskScheduler() for phase in ('_internal_test',): - rval = doebuild_spawn( - "%s %s" % (_shell_quote(EBUILD_SH_BINARY), phase), + + # Test EbuildSpawnProcess by calling doebuild.spawn() with + # returnpid=False. This case is no longer used by portage + # internals since EbuildPhase is used instead and that passes + # returnpid=True to doebuild.spawn(). + rval = doebuild_spawn("%s %s" % (_shell_quote( + os.path.join(settings["PORTAGE_BIN_PATH"], + os.path.basename(EBUILD_SH_BINARY))), phase), settings, free=1) self.assertEqual(rval, os.EX_OK) |