summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2008-12-20 20:22:39 +0000
committerZac Medico <zmedico@gentoo.org>2008-12-20 20:22:39 +0000
commitbcacfe9c1861d6efa250756f1380400e720eff7c (patch)
treedf51e5988e56b3c5985907ecd239eb5a838345c8
parentd2a8d312849ad694e957475497b07ddb98e3a2c5 (diff)
downloadportage-bcacfe9c1861d6efa250756f1380400e720eff7c.tar.gz
portage-bcacfe9c1861d6efa250756f1380400e720eff7c.tar.bz2
portage-bcacfe9c1861d6efa250756f1380400e720eff7c.zip
Adjust the EbuildNestedDie pattern so that it only matches when ( is surroundedv2.2_rc18
by whitespace. This filters out false positives triggered by sed expressions in net-analyzer/amap-5.2-r1 and media-libs/libsndfile-1.0.17-r1. Thanks to Diego Pettenò <flameeyes@g.o> for reporting. svn path=/main/trunk/; revision=12265
-rw-r--r--pym/repoman/checks.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 6f2c076c3..7565039f2 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -177,7 +177,7 @@ class EbuildNestedDie(LineCheck):
"""Check ebuild for nested die statements (die statements in subshells"""
repoman_check_name = 'ebuild.nesteddie'
- nesteddie_re = re.compile(r'^[^#]*\([^)]*\bdie\b')
+ nesteddie_re = re.compile(r'^[^#]*\s\(\s[^)]*\bdie\b')
def check(self, num, line):
if self.nesteddie_re.match(line):