summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZac Medico <zmedico@gentoo.org>2008-04-27 21:25:20 +0000
committerZac Medico <zmedico@gentoo.org>2008-04-27 21:25:20 +0000
commit12b18d776b62da31709d42f49903eb0c0423fcda (patch)
tree9e2c1e0a9e62cecf038876ea7e5ceca1dd78a497
parent14705faba9c742b8367f8aa176b6565081ad7f31 (diff)
downloadportage-12b18d776b62da31709d42f49903eb0c0423fcda.tar.gz
portage-12b18d776b62da31709d42f49903eb0c0423fcda.tar.bz2
portage-12b18d776b62da31709d42f49903eb0c0423fcda.zip
Fix the EbuildQuote check to ignore "echo" and the elog functions since
people might not want quotes in those cases. svn path=/main/trunk/; revision=10006
-rw-r--r--pym/repoman/checks.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index bc1c29115..8f9fd1abc 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -76,7 +76,10 @@ class EbuildQuote(LineCheck):
"""Ensure ebuilds have valid quoting around things like D,FILESDIR, etc..."""
repoman_check_name = 'ebuild.minorsyn'
- ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)|(^\s*(local|export)\s+)')
+ _ignored_commands = ["echo", "local", "export"]
+ _ignored_commands += ["eerror", "einfo", "elog", "eqawarn", "ewarn"]
+ ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)' + \
+ r'|(^\s*(' + "|".join(_ignored_commands) + r')\s+)')
var_names = ["D", "DISTDIR", "FILESDIR", "S", "T", "ROOT", "WORKDIR"]
# variables for games.eclass