summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlec Warner <antarus@gentoo.org>2007-01-12 04:07:38 +0000
committerAlec Warner <antarus@gentoo.org>2007-01-12 04:07:38 +0000
commitd053f260bcd65a4a922b172c5c04ce26cae1df8d (patch)
treeb323da07a72afa37d45e11f2a05e73a5b994fef0
parent392dcf713d51bd9678c2e726d1b1ed58f9f1d583 (diff)
downloadportage-d053f260bcd65a4a922b172c5c04ce26cae1df8d.tar.gz
portage-d053f260bcd65a4a922b172c5c04ce26cae1df8d.tar.bz2
portage-d053f260bcd65a4a922b172c5c04ce26cae1df8d.zip
comment the excepts in a few places
svn path=/main/trunk/; revision=5584
-rw-r--r--pym/portage_dep.py2
-rw-r--r--pym/portage_exec.py2
-rw-r--r--pym/portage_versions.py2
3 files changed, 3 insertions, 3 deletions
diff --git a/pym/portage_dep.py b/pym/portage_dep.py
index 271c5ef04..cc662d5ca 100644
--- a/pym/portage_dep.py
+++ b/pym/portage_dep.py
@@ -618,7 +618,7 @@ def match_from_list(mydep, candidate_list):
for x in candidate_list:
try:
result = pkgcmp(pkgsplit(x), mysplit)
- except ValueError:
+ except ValueError: # pkgcmp may return ValueError during int() conversion
writemsg("\nInvalid package name: %s\n" % x, noiselevel=-1)
raise
if result is None:
diff --git a/pym/portage_exec.py b/pym/portage_exec.py
index 7557ad724..252fed2a0 100644
--- a/pym/portage_exec.py
+++ b/pym/portage_exec.py
@@ -84,7 +84,7 @@ def run_exitfuncs():
func(*targs, **kargs)
except SystemExit:
exc_info = sys.exc_info()
- except:
+ except: # No idea what they called, so we need this broad except here.
dump_traceback("Error in portage_exec.run_exitfuncs", noiselevel=0)
exc_info = sys.exc_info()
diff --git a/pym/portage_versions.py b/pym/portage_versions.py
index 6aae094c0..6a354e0c2 100644
--- a/pym/portage_versions.py
+++ b/pym/portage_versions.py
@@ -222,7 +222,7 @@ def pkgsplit(mypkg,silent=1):
try:
int(myrev[1:])
revok=1
- except ValueError:
+ except ValueError: # from int()
pass
if revok:
verPos = -2