diff options
| author | Zac Medico <zmedico@gentoo.org> | 2012-09-25 20:15:51 -0700 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2012-09-25 20:15:51 -0700 |
| commit | 63970f5c610e16478c08459669dfc2e1abf8c0f2 (patch) | |
| tree | 00c0bfccac1008e2950ddcd757c551e647201754 /bin/repoman | |
| parent | 356b518fd996e4fd4719e9d350078326eb64c0d9 (diff) | |
| download | portage-63970f5c610e16478c08459669dfc2e1abf8c0f2.tar.gz portage-63970f5c610e16478c08459669dfc2e1abf8c0f2.tar.bz2 portage-63970f5c610e16478c08459669dfc2e1abf8c0f2.zip | |
Use constants for hardcoded *DEPEND lists.
Diffstat (limited to 'bin/repoman')
| -rwxr-xr-x | bin/repoman | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/bin/repoman b/bin/repoman index 6951bbe91..6caf791de 100755 --- a/bin/repoman +++ b/bin/repoman @@ -1872,11 +1872,11 @@ for x in effective_scanlist: inherited_wxwidgets_eclass = "wxwidgets" in inherited operator_tokens = set(["||", "(", ")"]) type_list, badsyntax = [], [] - for mytype in ("DEPEND", "HDEPEND", "RDEPEND", "PDEPEND", - "LICENSE", "PROPERTIES", "PROVIDE"): + for mytype in Package._dep_keys + ("LICENSE", "PROPERTIES", "PROVIDE"): mydepstr = myaux[mytype] - buildtime = mytype in ('DEPEND', 'HDEPEND') + buildtime = mytype in Package._buildtime_keys + runtime = mytype in Package._runtime_keys token_class = None if mytype.endswith("DEPEND"): token_class=portage.dep.Atom @@ -1889,7 +1889,7 @@ for x in effective_scanlist: badsyntax.append(str(e)) if atoms and mytype.endswith("DEPEND"): - if mytype in ("RDEPEND", "PDEPEND") and \ + if runtime and \ "test?" in mydepstr.split(): stats[mytype + '.suspect'] += 1 fails[mytype + '.suspect'].append(relative_path + \ @@ -1932,7 +1932,7 @@ for x in effective_scanlist: fails['wxwidgets.eclassnotused'].append( (relative_path + ": %ss on x11-libs/wxGTK" " without inheriting wxwidgets.eclass") % mytype) - elif mytype in ("PDEPEND", "RDEPEND"): + elif runtime: if not is_blocker and \ atom.cp in suspect_rdepend: stats[mytype + '.suspect'] += 1 @@ -2153,7 +2153,7 @@ for x in effective_scanlist: if prof.status == "dev": suffix=suffix+"indev" - for mytype in ("DEPEND", "HDEPEND", "PDEPEND", "RDEPEND"): + for mytype in Package._dep_keys: mykey = "dependency.bad" + suffix myvalue = myaux[mytype] |