- Remove ebuild.autotools repoman check since it produces lots

  of false positives (bug #207104) and its hard to parse bash

- Use QA_INTERCEPTORS in ebuild.sh to implement a runtime
  'QA Notice' when autotools is called directly

trunk r9235

svn path=/main/branches/2.1.2/; revision=9247

1 files changed, 1 insertions, 15 deletions

diff --git a/bin/repoman b/bin/repoman
index 674aa61fd..022897683 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -207,7 +207,6 @@ qahelp={
 	"ebuild.majorsyn":"This ebuild has a major syntax error that may cause the ebuild to fail partially or fully",
 	"ebuild.minorsyn":"This ebuild has a minor syntax error that contravenes gentoo coding style",
 	"ebuild.badheader":"This ebuild has a malformed header",
-	"ebuild.autotools":"Ebuild calls autotools directly instead of using autotools.eclass",
 	"metadata.missing":"Missing metadata.xml files",
 	"metadata.bad":"Bad metadata.xml files",
 	"virtual.versioned":"PROVIDE contains virtuals with versions",
@@ -225,7 +224,6 @@ qawarnings=[
 "ebuild.notadded",
 "ebuild.nostable",
 "ebuild.allmasked",
-"ebuild.autotools",
 "ebuild.nesteddie",
 "desktop.invalid",
 "digest.assumed",
@@ -1017,18 +1015,6 @@ class EbuildUselessCdS(LineCheck):
 		elif self.method_re.match(line):
 			self.check_next_line = True
 
-class Autotools(LineCheck):
-	"""Check for direct calls to autotools"""
-	repoman_check_name = 'ebuild.autotools'
-	re = re.compile(r'^[^#]*([^e]|^)(autoconf|automake|aclocal|libtoolize)')
-
-	def check(self, num, line):
-		"""Run the check on line and return error if there is one"""
-		m = self.re.match(line)
-		if m is not None:
-			return ("Direct calls to '%s'" % m.group(2)) + \
-				" instead of using autotools.eclass on line: %d"
-
 class EbuildQuotedA(LineCheck):
 	"""Ensure ebuilds have no quoting around ${A}"""
 
@@ -1040,7 +1026,7 @@ class EbuildQuotedA(LineCheck):
 		if match:
 			return "Quoted \"${A}\" on line: %d"
 
-_constant_checks = tuple((c() for c in (Autotools,
+_constant_checks = tuple((c() for c in (
 	EbuildQuote, EbuildUselessDodoc, EbuildUselessCdS,
 	EbuildNestedDie, EbuildQuotedA)))