diff options
| author | Zac Medico <zmedico@gentoo.org> | 2009-03-11 03:40:36 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2009-03-11 03:40:36 +0000 |
| commit | 49e640ef614ddd5c087457e158f6956a17fe0a26 (patch) | |
| tree | 6ccd1b55a8488005e524523a8aaec560b570c814 /pym/repoman | |
| parent | 2f6bbbe50964b89e2d17aa51cb0f07ecca19f003 (diff) | |
| download | portage-49e640ef614ddd5c087457e158f6956a17fe0a26.tar.gz portage-49e640ef614ddd5c087457e158f6956a17fe0a26.tar.bz2 portage-49e640ef614ddd5c087457e158f6956a17fe0a26.zip | |
Warn about WANT_AUTO(CONF|MAKE)=latest settings since they are redundant.
Thanks to Petteri Räty <betelgeuse@g.o> for the initial patch. (trunk r12583)
svn path=/main/branches/2.1.6/; revision=12864
Diffstat (limited to 'pym/repoman')
| -rw-r--r-- | pym/repoman/checks.py | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index c9ef91cfc..e89020980 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -328,13 +328,25 @@ class DeprecatedBindnowFlags(LineCheck): re = re.compile(r'.*\$\(bindnow-flags\)') error = errors.DEPRECATED_BINDNOW_FLAGS +class WantAutoDefaultValue(LineCheck): + """Check setting WANT_AUTO* to latest (default value).""" + repoman_check_name = 'ebuild.minorsyn' + _re = re.compile(r'^WANT_AUTO(CONF|MAKE)=(\'|")?latest') + + def check(self, num, line): + m = self._re.match(line) + if m is not None: + return 'WANT_AUTO' + m.group(1) + \ + ' redundantly set to default value "latest" on line: %d' + _constant_checks = tuple((c() for c in ( EbuildHeader, EbuildWhitespace, EbuildQuote, EbuildAssignment, EbuildUselessDodoc, EbuildUselessCdS, EbuildNestedDie, EbuildPatches, EbuildQuotedA, IUseUndefined, ImplicitRuntimeDeps, InheritAutotools, - EMakeParallelDisabled, DeprecatedBindnowFlags))) + EMakeParallelDisabled, DeprecatedBindnowFlags, + WantAutoDefaultValue))) def run_checks(contents, pkg): checks = _constant_checks |