diff options
| author | Zac Medico <zmedico@gentoo.org> | 2011-10-02 13:22:07 -0700 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2011-10-02 13:22:07 -0700 |
| commit | 77b651300731ec007cd535a83b8ee9a898602783 (patch) | |
| tree | b86630c88b2dee807605dcf3a4a01125c344e583 /pym | |
| parent | 053ce10dcaa85a61d0049cd08b4e725d67a271f6 (diff) | |
| download | portage-77b651300731ec007cd535a83b8ee9a898602783.tar.gz portage-77b651300731ec007cd535a83b8ee9a898602783.tar.bz2 portage-77b651300731ec007cd535a83b8ee9a898602783.zip | |
Prefer slot conflict over blocker display.
The slot conflict display has better noise reduction than the
unsatisfied blockers display, so skip unsatisfied blockers display if
there are slot conflicts (see bug #385391). Note that this reverses
the logic from bug 159310, since the slot conflict display has evolved
a lot since then.
Diffstat (limited to 'pym')
| -rw-r--r-- | pym/_emerge/depgraph.py | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py index ad0455112..66cba0433 100644 --- a/pym/_emerge/depgraph.py +++ b/pym/_emerge/depgraph.py @@ -6170,13 +6170,14 @@ class depgraph(object): self._show_circular_deps( self._dynamic_config._circular_deps_for_display) - # The user is only notified of a slot conflict if - # there are no unresolvable blocker conflicts. - if self._dynamic_config._unsatisfied_blockers_for_display is not None: + # The slot conflict display has better noise reduction than + # the unsatisfied blockers display, so skip unsatisfied blockers + # display if there are slot conflicts (see bug #385391). + if self._dynamic_config._slot_collision_info: + self._show_slot_collision_notice() + elif self._dynamic_config._unsatisfied_blockers_for_display is not None: self._show_unsatisfied_blockers( self._dynamic_config._unsatisfied_blockers_for_display) - elif self._dynamic_config._slot_collision_info: - self._show_slot_collision_notice() else: self._show_missed_update() |