diff options
| author | Zac Medico <zmedico@gentoo.org> | 2010-01-29 18:51:48 +0000 |
|---|---|---|
| committer | Zac Medico <zmedico@gentoo.org> | 2010-01-29 18:51:48 +0000 |
| commit | 2a45859c02ff2aee0f0d1d21a68ddf5cb28dd2dc (patch) | |
| tree | 86797127aa1ec1ca4e6d147276741c3354a60463 /pym | |
| parent | 9035ac2b27171328c7b47aa43aa44400d1deb9d5 (diff) | |
| download | portage-2a45859c02ff2aee0f0d1d21a68ddf5cb28dd2dc.tar.gz portage-2a45859c02ff2aee0f0d1d21a68ddf5cb28dd2dc.tar.bz2 portage-2a45859c02ff2aee0f0d1d21a68ddf5cb28dd2dc.zip | |
Add a warning for built_with_use. Thanks to Petteri Räty <betelgeuse@g.o> for
this patch. (trunk r15209)
svn path=/main/branches/2.1.7/; revision=15261
Diffstat (limited to 'pym')
| -rw-r--r-- | pym/repoman/checks.py | 9 | ||||
| -rw-r--r-- | pym/repoman/errors.py | 1 |
2 files changed, 8 insertions, 2 deletions
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 4e83e6653..36e074c9f 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -432,6 +432,12 @@ class SrcUnpackPatches(PhaseCheck): return ("'%s'" % m.group(1)) + \ " call should be moved to src_prepare from line: %d" +class BuiltWithUse(LineCheck): + repoman_check_name = 'ebuild.minorsyn' + ignore_line = re.compile(r'^\s*#') + re = re.compile('^.*built_with_use') + error = errors.BUILT_WITH_USE + # EAPI-4 checks class Eapi4IncompatibleFuncs(LineCheck): repoman_check_name = 'EAPI.incompatible' @@ -467,7 +473,6 @@ class Eapi4GoneVars(LineCheck): return ("variable '$%s'" % m.group(1)) + \ " is gone in EAPI=4 on line: %d" - _constant_checks = tuple((c() for c in ( EbuildHeader, EbuildWhitespace, EbuildBlankLine, EbuildQuote, EbuildAssignment, EbuildUselessDodoc, @@ -476,7 +481,7 @@ _constant_checks = tuple((c() for c in ( IUseUndefined, InheritAutotools, EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded, DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue, - SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars))) + SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse))) _here_doc_re = re.compile(r'.*\s<<[-]?(\w+)$') diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py index b62af12b3..cd1d7e3d7 100644 --- a/pym/repoman/errors.py +++ b/pym/repoman/errors.py @@ -18,3 +18,4 @@ EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEO DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d' EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d' NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)' +BUILT_WITH_USE = 'built_with_use on line: %d' |