From 60f19452091160bbf716fc7746f80632189abfa7 Mon Sep 17 00:00:00 2001 From: Arfrever Frehtes Taifersar Arahesis Date: Fri, 13 Aug 2010 16:23:35 +0200 Subject: Fix some comments. --- bin/ebuild-helpers/dohtml | 2 +- bin/ebuild-helpers/portageq | 2 +- bin/ebuild-ipc | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/ebuild-helpers/dohtml b/bin/ebuild-helpers/dohtml index c5bfd0637..e1ab7d970 100755 --- a/bin/ebuild-helpers/dohtml +++ b/bin/ebuild-helpers/dohtml @@ -6,7 +6,7 @@ source "${PORTAGE_BIN_PATH:-/usr/lib/portage/bin}"/isolated-functions.sh PORTAGE_BIN_PATH=${PORTAGE_BIN_PATH:-/usr/lib/portage/bin} PORTAGE_PYM_PATH=${PORTAGE_PYM_PATH:-/usr/lib/portage/pym} -# Set EPYTHON variable as empty so that dohtml doesn't try +# Set EPYTHON variable as empty so that dohtml.py doesn't try # to use potentially unsupported version of Python. EPYTHON= PYTHONPATH=$PORTAGE_PYM_PATH${PYTHONPATH:+:}$PYTHONPATH \ "$PORTAGE_BIN_PATH/dohtml.py" "$@" diff --git a/bin/ebuild-helpers/portageq b/bin/ebuild-helpers/portageq index d1a1fb52b..3a06fdd68 100755 --- a/bin/ebuild-helpers/portageq +++ b/bin/ebuild-helpers/portageq @@ -4,7 +4,7 @@ PORTAGE_BIN_PATH=${PORTAGE_BIN_PATH:-/usr/lib/portage/bin} PORTAGE_PYM_PATH=${PORTAGE_PYM_PATH:-/usr/lib/portage/pym} -# Set EPYTHON variable as empty so that dohtml doesn't try +# Set EPYTHON variable as empty so that portageq doesn't try # to use potentially unsupported version of Python. EPYTHON= PYTHONPATH=$PORTAGE_PYM_PATH${PYTHONPATH:+:}$PYTHONPATH \ exec "$PORTAGE_BIN_PATH/portageq" "$@" diff --git a/bin/ebuild-ipc b/bin/ebuild-ipc index b30b89aea..b828a35cd 100755 --- a/bin/ebuild-ipc +++ b/bin/ebuild-ipc @@ -4,7 +4,7 @@ PORTAGE_BIN_PATH=${PORTAGE_BIN_PATH:-/usr/lib/portage/bin} PORTAGE_PYM_PATH=${PORTAGE_PYM_PATH:-/usr/lib/portage/pym} -# Set EPYTHON variable as empty so that dohtml doesn't try +# Set EPYTHON variable as empty so that ebuild-ipc.py doesn't try # to use potentially unsupported version of Python. EPYTHON= PYTHONPATH=$PORTAGE_PYM_PATH${PYTHONPATH:+:}$PYTHONPATH \ exec "$PORTAGE_BIN_PATH/ebuild-ipc.py" "$@" -- cgit v1.2.3-1-g7c22 From a1164e1be0293e4340d7f3961b748c1c2f096ee7 Mon Sep 17 00:00:00 2001 From: Arfrever Frehtes Taifersar Arahesis Date: Fri, 13 Aug 2010 16:28:22 +0200 Subject: Remove files generated by testCompileModules. --- pym/portage/tests/lint/test_compile_modules.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pym/portage/tests/lint/test_compile_modules.py b/pym/portage/tests/lint/test_compile_modules.py index c6e68946e..2e5ab7e2d 100644 --- a/pym/portage/tests/lint/test_compile_modules.py +++ b/pym/portage/tests/lint/test_compile_modules.py @@ -47,3 +47,4 @@ class CompileModulesTestCase(TestCase): if do_compile: cfile += (__debug__ and 'c' or 'o') py_compile.compile(x, cfile=cfile, doraise=True) + os.unlink(cfile) -- cgit v1.2.3-1-g7c22 From c33858cc3a7cd510163aa4a406bcf95585807da4 Mon Sep 17 00:00:00 2001 From: Arfrever Frehtes Taifersar Arahesis Date: Fri, 13 Aug 2010 16:46:34 +0200 Subject: Add QA check for static libraries in Python site-packages directories. --- bin/misc-functions.sh | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index 9777c9954..4e8b1b766 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -542,8 +542,18 @@ install_qa_check() { if [[ -n ${f} ]] ; then vecho -ne '\a\n' eqawarn "QA Notice: Byte-compiled Python modules have been found. python_mod_optimize()" - eqawarn " and python_mod_cleanup() functions python.eclass should be used to" - eqawarn " handle byte-compiled Python modules." + eqawarn " and python_mod_cleanup() functions from python.eclass should be used" + eqawarn " to handle byte-compiled Python modules." + eqawarn "${f}" + vecho -ne '\a\n' + fi + + f=$(find "${D}"usr/lib*/python*/site-packages -name '*.a' 2>/dev/null | sed "s:${D}:/:") + if [[ -n ${f} ]] ; then + vecho -ne '\a\n' + eqawarn "QA Notice: Static libraries have been found in Python site-packages" + eqawarn " directories. Build system should be modified to not generate" + eqawarn " these files and object files generated only for these files." eqawarn "${f}" vecho -ne '\a\n' fi -- cgit v1.2.3-1-g7c22 From a576d0e636feb2057636f3fb051fe946f35433df Mon Sep 17 00:00:00 2001 From: Arfrever Frehtes Taifersar Arahesis Date: Fri, 13 Aug 2010 16:52:54 +0200 Subject: Add QA check for libtool libraries in Python site-packages directories. --- bin/misc-functions.sh | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index 4e8b1b766..c965495b6 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -558,6 +558,15 @@ install_qa_check() { vecho -ne '\a\n' fi + f=$(find "${D}"usr/lib*/python*/site-packages -name '*.la' 2>/dev/null | sed "s:${D}:/:") + if [[ -n ${f} ]] ; then + vecho -ne '\a\n' + eqawarn "QA Notice: Libtool libraries have been found in Python site-packages" + eqawarn " directories. These files should not be installed." + eqawarn "${f}" + vecho -ne '\a\n' + fi + # Portage regenerates this on the installed system. rm -f "${D}"/usr/share/info/dir{,.gz,.bz2} -- cgit v1.2.3-1-g7c22