From da34bceea64b7bb19a6c2a831d6c593f0cbe3290 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Tue, 25 Mar 2008 04:04:44 +0000 Subject: Bug #212621 - Make the EbuildQuote check do quoting validation for misc variables from games.eclass. svn path=/main/trunk/; revision=9507 --- pym/repoman/checks.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index ea76f6a01..aa5bf1845 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -77,7 +77,14 @@ class EbuildQuote(LineCheck): repoman_check_name = 'ebuild.minorsyn' ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)|(^\s*(local|export)\s+)') - var_names = r'(D|DISTDIR|FILESDIR|S|T|ROOT|WORKDIR)' + var_names = ["D", "DISTDIR", "FILESDIR", "S", "T", "ROOT", "WORKDIR"] + + # variables for games.eclass + var_names += ["Ddir", "dir", "GAMES_PREFIX_OPT", "GAMES_DATADIR", + "GAMES_DATADIR_BASE", "GAMES_SYSCONFDIR", "GAMES_STATEDIR", + "GAMES_LOGDIR", "GAMES_BINDIR"] + + var_names = "(%s)" % "|".join(var_names) var_reference = re.compile(r'\$(\{'+var_names+'\}|' + \ var_names + '\W)') missing_quotes = re.compile(r'(\s|^)[^"\'\s]*\$\{?' + var_names + \ -- cgit v1.2.3-1-g7c22