From f7ec7a4db6543e1fd3a13c341a37ccb667956978 Mon Sep 17 00:00:00 2001
From: Zac Medico <zmedico@gentoo.org>
Date: Wed, 8 Aug 2012 18:59:21 -0700
Subject: repoman: remove IUSE.undefined check

This was suggested in the "Don't require assignment of empty variables
in ebuilds?" thread on the gentoo-dev mailing list:

  http://thread.gmane.org/gmane.linux.gentoo.devel/78806
---
 bin/repoman           |  2 --
 man/repoman.1         |  3 ---
 pym/repoman/checks.py | 22 +---------------------
 3 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/bin/repoman b/bin/repoman
index c5dce0381..b50fac82c 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -375,7 +375,6 @@ qahelp={
 	"LIVEVCS.unmasked":"This ebuild is a live checkout from a VCS but has keywords and is not masked in the global package.mask.",
 	"IUSE.invalid":"This ebuild has a variable in IUSE that is not in the use.desc or its metadata.xml file",
 	"IUSE.missing":"This ebuild has a USE conditional which references a flag that is not listed in IUSE",
-	"IUSE.undefined":"This ebuild does not define IUSE (style guideline says to define IUSE even when empty)",
 	"LICENSE.invalid":"This ebuild is listing a license that doesnt exist in portages license/ dir.",
 	"KEYWORDS.invalid":"This ebuild contains KEYWORDS that are not listed in profiles/arch.list or for which no valid profile was found",
 	"RDEPEND.implicit":"RDEPEND is unset in the ebuild which triggers implicit RDEPEND=$DEPEND assignment (prior to EAPI 4)",
@@ -421,7 +420,6 @@ qawarnings = set((
 "KEYWORDS.dropped",
 "KEYWORDS.stupid",
 "KEYWORDS.missing",
-"IUSE.undefined",
 "PDEPEND.suspect",
 "RDEPEND.implicit",
 "RDEPEND.suspect",
diff --git a/man/repoman.1 b/man/repoman.1
index b8c0f48e3..0ea835a93 100644
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -170,9 +170,6 @@ This ebuild has a variable in IUSE that is not in the use.desc or its metadata.x
 .B IUSE.missing
 This ebuild has a USE conditional which references a flag that is not listed in IUSE
 .TP
-.B IUSE.undefined
-This ebuild does not define IUSE (style guideline says to define IUSE even when empty)
-.TP
 .B KEYWORDS.dropped
 Ebuilds that appear to have dropped KEYWORDS for some arch
 .TP
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index ca4c260b1..9c076ead4 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -640,26 +640,6 @@ if not _ENABLE_INHERIT_CHECK:
 		}
 	}
 
-class IUseUndefined(LineCheck):
-	"""
-	Make sure the ebuild defines IUSE (style guideline
-	says to define IUSE even when empty).
-	"""
-
-	repoman_check_name = 'IUSE.undefined'
-	_iuse_def_re = re.compile(r'^IUSE=.*')
-
-	def new(self, pkg):
-		self._iuse_def = None
-
-	def check(self, num, line):
-		if self._iuse_def is None:
-			self._iuse_def = self._iuse_def_re.match(line)
-
-	def end(self):
-		if self._iuse_def is None:
-			yield 'IUSE is not defined'
-
 class EMakeParallelDisabled(PhaseCheck):
 	"""Check for emake -j1 calls which disable parallelization."""
 	repoman_check_name = 'upstream.workaround'
@@ -818,7 +798,7 @@ _constant_checks = tuple(chain((c() for c in (
 	EbuildAssignment, Eapi3EbuildAssignment, EbuildUselessDodoc,
 	EbuildUselessCdS, EbuildNestedDie,
 	EbuildPatches, EbuildQuotedA, EapiDefinition,
-	ImplicitRuntimeDeps, IUseUndefined,
+	ImplicitRuntimeDeps,
 	EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded,
 	DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,
 	SrcCompileEconf, Eapi3DeprecatedFuncs, NoOffsetWithHelpers,
-- 
cgit v1.2.3-1-g7c22