From 3f64053d6d09603b8b031b3020d6c09556fbf185 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Tue, 30 Sep 2008 01:06:20 +0000 Subject: Now that elog_base() uses 'echo -e' to expand escape codes prior to using 'read' to split on newlines, it's safe to use newlines as delimiters in the log file since 'read' is guaranteed to split any newlines contained in the arguments. svn path=/main/trunk/; revision=11601 --- bin/isolated-functions.sh | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'bin/isolated-functions.sh') diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh index 74692c8a7..be8716be6 100755 --- a/bin/isolated-functions.sh +++ b/bin/isolated-functions.sh @@ -170,12 +170,8 @@ elog_base() { return 1 ;; esac - # Note: Even though the message is split on $'\n' here, it's still - # not entirely safe to use it as a delimiter in the log file since - # there can still be escaped newlines that will be expanded due to - # the echo -e parameter. echo -e "$@" | while read line ; do - echo -ne "${messagetype} ${line}\n\0" >> \ + echo "${messagetype} ${line}" >> \ "${T}/logging/${EBUILD_PHASE:-other}" done return 0 -- cgit v1.2.3-1-g7c22