From 1de36ad91237651277b9e4b7e0db819efb5e6997 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Wed, 21 Dec 2011 13:28:47 -0800 Subject: Use *FLAGS for CFLAGS ignorance checks. Current *FLAGS variables include CFLAGS, CXXFLAGS, FFLAGS, and FCFLAGS. Not that this check is only enabled if every one of these variables contains -frecord-gcc-switches, since otherwise the check could result in false positive results. --- bin/misc-functions.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'bin/misc-functions.sh') diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh index 4cba51acc..c74b4a411 100755 --- a/bin/misc-functions.sh +++ b/bin/misc-functions.sh @@ -308,8 +308,13 @@ install_qa_check() { sleep 1 fi - # Check for files built without respecting CFLAGS + # Check for files built without respecting *FLAGS. Note that + # -frecord-gcc-switches must be in all *FLAGS variables, in + # order to avoid false positive results here. if [[ "${CFLAGS}" == *-frecord-gcc-switches* ]] && \ + [[ "${CXXFLAGS}" == *-frecord-gcc-switches* ]] && \ + [[ "${FFLAGS}" == *-frecord-gcc-switches* ]] && \ + [[ "${FCFLAGS}" == *-frecord-gcc-switches* ]] && \ ! has binchecks ${RESTRICT} ; then qa_var="QA_CFLAGS_IGNORED_${ARCH/-/_}" eval "[[ -n \${!qa_var} ]] && QA_CFLAGS_IGNORED=(\"\${${qa_var}[@]}\")" -- cgit v1.2.3-1-g7c22