From 0f55a5a75c410d73779f7090784d06e40e03a1c9 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Sat, 11 Feb 2012 12:05:17 -0800 Subject: PollScheduler: return None from _schedule_tasks The _keep_scheduling() template method is used instead. --- pym/_emerge/PollScheduler.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'pym/_emerge/PollScheduler.py') diff --git a/pym/_emerge/PollScheduler.py b/pym/_emerge/PollScheduler.py index 3b3ef67df..e270e6ad0 100644 --- a/pym/_emerge/PollScheduler.py +++ b/pym/_emerge/PollScheduler.py @@ -70,6 +70,14 @@ class PollScheduler(object): """ raise NotImplementedError() + def _keep_scheduling(self): + """ + @rtype: bool + @returns: True if there may be remaining tasks to schedule, + False otherwise. + """ + return False + def _schedule_tasks(self): """ This is called from inside the _schedule() method, which @@ -83,7 +91,7 @@ class PollScheduler(object): Unless this method is used to perform user interface updates, or something like that, the first thing it should do is check the state of _terminated_tasks and if that is True then it - should return False immediately (since there's no need to + should return immediately (since there's no need to schedule anything after _terminate_tasks() has been called). """ pass @@ -105,7 +113,7 @@ class PollScheduler(object): self._terminated_tasks = True self._terminate_tasks() - return self._schedule_tasks() + self._schedule_tasks() finally: self._scheduling = False @@ -125,9 +133,6 @@ class PollScheduler(object): while self._is_work_scheduled(): self.sched_iface.iteration() - def _keep_scheduling(self): - return False - def _is_work_scheduled(self): return bool(self._running_job_count()) -- cgit v1.2.3-1-g7c22