From 365e9a71e5dff59be90f4ca16eefb245031c1e7f Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Thu, 26 Aug 2010 22:43:31 -0700 Subject: Add a IUSE.missing repoman category for packages that have a USE conditional which references a flag that is not listed in IUSE. Also split out a Package._metadata_exception() method to handle IUSE.missing for *DEPEND and SRC_URI. --- pym/_emerge/Package.py | 47 +++++++++++++++++++++++++---------------------- 1 file changed, 25 insertions(+), 22 deletions(-) (limited to 'pym/_emerge') diff --git a/pym/_emerge/Package.py b/pym/_emerge/Package.py index 495686ff4..f9b42f0de 100644 --- a/pym/_emerge/Package.py +++ b/pym/_emerge/Package.py @@ -87,27 +87,7 @@ class Package(Task): use_reduce(v, eapi=dep_eapi, is_valid_flag=dep_valid_flag, token_class=Atom) except portage.exception.InvalidDependString as e: - if not self.installed: - categorized_error = False - if e.errors: - for error in e.errors: - if getattr(error, 'category', None) is None: - continue - categorized_error = True - self._invalid_metadata(error.category, - "%s: %s" % (k, error)) - - if not categorized_error: - self._invalid_metadata(k + ".syntax", - "%s: %s" % (k, e)) - else: - # For installed packages, show the path of the file - # containing the invalid metadata, since the user may - # want to fix the deps by hand. - vardb = self.root_config.trees['vartree'].dbapi - path = vardb.getpath(self.cpv, filename=k) - self._invalid_metadata(k + ".syntax", - "%s: %s in '%s'" % (k, e, path)) + self._metadata_exception(k, e) k = 'REQUIRED_USE' v = self.metadata.get(k) @@ -131,7 +111,7 @@ class Package(Task): is_valid_flag=self.iuse.is_valid_flag) except portage.exception.InvalidDependString as e: if not self.installed: - self._invalid_metadata(k + ".syntax", "%s: %s" % (k, e)) + self._metadata_exception(k, e) def copy(self): return Package(built=self.built, cpv=self.cpv, depth=self.depth, @@ -216,6 +196,29 @@ class Package(Task): return True + def _metadata_exception(self, k, e): + if not self.installed: + categorized_error = False + if e.errors: + for error in e.errors: + if getattr(error, 'category', None) is None: + continue + categorized_error = True + self._invalid_metadata(error.category, + "%s: %s" % (k, error)) + + if not categorized_error: + self._invalid_metadata(k + ".syntax", + "%s: %s" % (k, e)) + else: + # For installed packages, show the path of the file + # containing the invalid metadata, since the user may + # want to fix the deps by hand. + vardb = self.root_config.trees['vartree'].dbapi + path = vardb.getpath(self.cpv, filename=k) + self._invalid_metadata(k + ".syntax", + "%s: %s in '%s'" % (k, e, path)) + def _invalid_metadata(self, msg_type, msg): if self.invalid is None: self.invalid = {} -- cgit v1.2.3-1-g7c22