From 5a24743e55acedcbae06b97401c6e39b0d5faa98 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Thu, 25 Aug 2011 14:48:45 -0700 Subject: python3.2 fixes: ResourceWarning: unclosed file --- pym/portage/elog/messages.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'pym/portage/elog') diff --git a/pym/portage/elog/messages.py b/pym/portage/elog/messages.py index 6c1580a37..50e0ab10a 100644 --- a/pym/portage/elog/messages.py +++ b/pym/portage/elog/messages.py @@ -43,9 +43,10 @@ def collect_ebuild_messages(path): logentries[msgfunction] = [] lastmsgtype = None msgcontent = [] - for l in io.open(_unicode_encode(filename, + f = io.open(_unicode_encode(filename, encoding=_encodings['fs'], errors='strict'), - mode='r', encoding=_encodings['repo.content'], errors='replace'): + mode='r', encoding=_encodings['repo.content'], errors='replace') + for l in f: if not l: continue try: @@ -65,6 +66,7 @@ def collect_ebuild_messages(path): logentries[msgfunction].append((lastmsgtype, msgcontent)) msgcontent = [msg] lastmsgtype = msgtype + f.close() if msgcontent: logentries[msgfunction].append((lastmsgtype, msgcontent)) -- cgit v1.2.3-1-g7c22