From 7411bc1bde9734df9eb00b19044929e4047b8652 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Thu, 12 Feb 2009 23:12:41 +0000 Subject: =?UTF-8?q?Add=20a=20new=20"portage.internal"=20warning=20for=20pr?= =?UTF-8?q?epalldocs=20usage=20since=20the=20council=20ruled=20that=20it?= =?UTF-8?q?=20shouldn't=20be=20used=20in=20ebuilds.=20Thanks=20to=20Petter?= =?UTF-8?q?i=20R=C3=A4ty=20=20for=20the=20initial=20patch.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit svn path=/main/trunk/; revision=12603 --- pym/repoman/checks.py | 11 ++++++++++- pym/repoman/errors.py | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) (limited to 'pym/repoman') diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index e89020980..aee6d7c97 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -339,6 +339,15 @@ class WantAutoDefaultValue(LineCheck): return 'WANT_AUTO' + m.group(1) + \ ' redundantly set to default value "latest" on line: %d' +class PortageInternal(LineCheck): + """ + In February 2009 the Gentoo council ruled that + prepalldocs is a Portage internal. + """ + repoman_check_name = 'portage.internal' + re = re.compile(r'[^#]*\bprepalldocs\b') + error = errors.PREPALLDOCS_ERROR + _constant_checks = tuple((c() for c in ( EbuildHeader, EbuildWhitespace, EbuildQuote, EbuildAssignment, EbuildUselessDodoc, @@ -346,7 +355,7 @@ _constant_checks = tuple((c() for c in ( EbuildPatches, EbuildQuotedA, IUseUndefined, ImplicitRuntimeDeps, InheritAutotools, EMakeParallelDisabled, DeprecatedBindnowFlags, - WantAutoDefaultValue))) + WantAutoDefaultValue, PortageInternal))) def run_checks(contents, pkg): checks = _constant_checks diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py index 7f45bea21..205913951 100644 --- a/pym/repoman/errors.py +++ b/pym/repoman/errors.py @@ -15,3 +15,4 @@ PATCHES_ERROR = 'PATCHES is not a bash array on line: %d' REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d' EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)' DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d' +PREPALLDOCS_ERROR = 'prepalldocs called on line: %d' -- cgit v1.2.3-1-g7c22