From 0ee4c2b7195e03c828dc4f1ef85825509a5fe77a Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Sun, 15 May 2011 23:17:27 -0700 Subject: _LockProcess: handle process failure if cancelled --- pym/_emerge/AsynchronousLock.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'pym') diff --git a/pym/_emerge/AsynchronousLock.py b/pym/_emerge/AsynchronousLock.py index 6fa2bf632..b62b684f1 100644 --- a/pym/_emerge/AsynchronousLock.py +++ b/pym/_emerge/AsynchronousLock.py @@ -176,7 +176,7 @@ class _LockProcess(AbstractPollTask): """ __slots__ = ('path', 'scheduler',) + \ - ('_proc', '_files', '_reg_id') + ('_proc', '_files', '_reg_id', '_unlocked') def _start(self): in_pr, in_pw = os.pipe() @@ -201,8 +201,14 @@ class _LockProcess(AbstractPollTask): os.close(in_pw) def _proc_exit(self, proc): - if proc.returncode != os.EX_OK: - # There's no good reason for locks to fail. + if proc.returncode != os.EX_OK and \ + not self.cancelled and \ + not self._unlocked: + # Typically, lock process failure should only happen + # if it's killed by a signal. We don't want lost + # locks going unnoticed, so it's only safe to ignore + # if either the cancel() or unlock() methods have + # been previously called. raise AssertionError('lock process failed with returncode %s' \ % (proc.returncode,)) @@ -244,6 +250,7 @@ class _LockProcess(AbstractPollTask): raise AssertionError('not locked') if self.returncode is None: raise AssertionError('lock not acquired yet') + self._unlocked = True self._files['pipe_out'].write(b'\0') self._files['pipe_out'].close() self._files = None -- cgit v1.2.3-1-g7c22