From 6b2dfba4b27544af98a096ec39f3e5989f472056 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Wed, 30 Jan 2008 22:49:47 +0000 Subject: - Remove ebuild.autotools repoman check since it produces lots of false positives (bug #207104) and its hard to parse bash - Use QA_INTERCEPTORS in ebuild.sh to implement a runtime 'QA Notice' when autotools is called directly svn path=/main/trunk/; revision=9235 --- pym/repoman/checks.py | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) (limited to 'pym') diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 269101981..462199722 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -185,19 +185,6 @@ class EbuildUselessCdS(LineCheck): self.check_next_line = True -class Autotools(LineCheck): - """Check for direct calls to autotools""" - repoman_check_name = 'ebuild.autotools' - re = re.compile(r'^[^#]*([^e]|^)(autoconf|automake|aclocal|libtoolize)') - - def check(self, num, line): - """Run the check on line and return error if there is one""" - autotools_match = self.re.match(line) - if autotools_match is not None: - return ("Direct calls to '%s'" % autotools_match.group(2)) + \ - " instead of using autotools.eclass on line: %d" - - class EbuildQuotedA(LineCheck): """Ensure ebuilds have no quoting around ${A}""" @@ -209,7 +196,7 @@ class EbuildQuotedA(LineCheck): if match: return "Quoted \"${A}\" on line: %d" -_constant_checks = tuple((c() for c in (Autotools, +_constant_checks = tuple((c() for c in ( EbuildWhitespace, EbuildQuote, EbuildAssignment, EbuildUselessDodoc, EbuildUselessCdS, EbuildNestedDie, EbuildQuotedA))) -- cgit v1.2.3-1-g7c22