From 85cdc08a1274a2953b0ee19d4d0b6f96caab0490 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Sun, 31 Aug 2008 07:13:54 +0000 Subject: =?UTF-8?q?Add=20a=20warning=20for=20emake=20-j1=20calls=20which?= =?UTF-8?q?=20disable=20parallelization.=20Thanks=20to=20Diego=20"Flameeye?= =?UTF-8?q?s"=20Petten=C3=B2=20for=20the=20suggestion.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit svn path=/main/trunk/; revision=11480 --- pym/repoman/checks.py | 9 ++++++++- pym/repoman/errors.py | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) (limited to 'pym') diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index 4b002568f..f7d7ce79d 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -268,12 +268,19 @@ class IUseUndefined(LineCheck): if self._iuse_def is None: yield 'IUSE is not defined' +class EMakeParallelDisabled(LineCheck): + """Check for emake -j1 calls which disable parallelization.""" + repoman_check_name = 'ebuild.minorsyn' + re = re.compile(r'^\s*emake\s*-j\s*1\s') + error = errors.EMAKE_PARALLEL_DISABLED + _constant_checks = tuple((c() for c in ( EbuildHeader, EbuildWhitespace, EbuildQuote, EbuildAssignment, EbuildUselessDodoc, EbuildUselessCdS, EbuildNestedDie, EbuildPatches, EbuildQuotedA, - IUseUndefined, InheritAutotools))) + IUseUndefined, InheritAutotools, + EMakeParallelDisabled))) def run_checks(contents, pkg): checks = _constant_checks diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py index 90fa83820..c6577f945 100644 --- a/pym/repoman/errors.py +++ b/pym/repoman/errors.py @@ -13,3 +13,4 @@ MISSING_QUOTES_ERROR = 'Unquoted Variable on line: %d' NESTED_DIE_ERROR = 'Ebuild calls die in a subshell on line: %d' PATCHES_ERROR = 'PATCHES is not a bash array on line: %d' REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d' +EMAKE_PARALLEL_DISABLED = 'Ebuild calls emake -j1 on line: %d' -- cgit v1.2.3-1-g7c22