diff options
| author | Chris St. Pierre <chris.a.st.pierre@gmail.com> | 2012-09-26 09:48:58 -0400 |
|---|---|---|
| committer | Chris St. Pierre <chris.a.st.pierre@gmail.com> | 2012-09-26 10:05:22 -0400 |
| commit | aeddf10f2e129c70b182e91b727ccc8028e3fd45 (patch) | |
| tree | 2213bf1a27912b75a7b160a0b2494acee052be19 /src/lib/Bcfg2/Client/Tools/MacPorts.py | |
| parent | be0e43af56fbd56dbb3f8d0266503e7b820f2c11 (diff) | |
| download | bcfg2-aeddf10f2e129c70b182e91b727ccc8028e3fd45.tar.gz bcfg2-aeddf10f2e129c70b182e91b727ccc8028e3fd45.tar.bz2 bcfg2-aeddf10f2e129c70b182e91b727ccc8028e3fd45.zip | |
made full pylint checks the default, expanded pylint coverage to lots of tools
Diffstat (limited to 'src/lib/Bcfg2/Client/Tools/MacPorts.py')
| -rw-r--r-- | src/lib/Bcfg2/Client/Tools/MacPorts.py | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/src/lib/Bcfg2/Client/Tools/MacPorts.py b/src/lib/Bcfg2/Client/Tools/MacPorts.py index 9724fab57..d768019a9 100644 --- a/src/lib/Bcfg2/Client/Tools/MacPorts.py +++ b/src/lib/Bcfg2/Client/Tools/MacPorts.py @@ -29,7 +29,7 @@ class MacPorts(Bcfg2.Client.Tools.PkgTool): self.logger.info(" pkgname: %s version: %s" % (pkgname, version)) self.installed[pkgname] = version - def VerifyPackage(self, entry, modlist): + def VerifyPackage(self, entry, _): """Verify Package status for entry.""" if not 'version' in entry.attrib: self.logger.info("Cannot verify unversioned package %s" % @@ -37,8 +37,8 @@ class MacPorts(Bcfg2.Client.Tools.PkgTool): return False if entry.attrib['name'] in self.installed: - if (self.installed[entry.attrib['name']] == entry.attrib['version'] or - entry.attrib['version'] == 'any'): + if (self.installed[entry.attrib['name']] == entry.attrib['version'] + or entry.attrib['version'] == 'any'): #if not self.setup['quick'] and \ # entry.get('verify', 'true') == 'true': #FIXME: We should be able to check this once @@ -46,10 +46,11 @@ class MacPorts(Bcfg2.Client.Tools.PkgTool): return True else: self.logger.info(" %s: Wrong version installed. " - "Want %s, but have %s" % (entry.get("name"), - entry.get("version"), - self.installed[entry.get("name")], - )) + "Want %s, but have %s" % + (entry.get("name"), + entry.get("version"), + self.installed[entry.get("name")], + )) entry.set('current_version', self.installed[entry.get('name')]) return False |