diff options
| author | Chris St. Pierre <chris.a.st.pierre@gmail.com> | 2012-09-26 09:48:58 -0400 |
|---|---|---|
| committer | Chris St. Pierre <chris.a.st.pierre@gmail.com> | 2012-09-26 10:05:22 -0400 |
| commit | aeddf10f2e129c70b182e91b727ccc8028e3fd45 (patch) | |
| tree | 2213bf1a27912b75a7b160a0b2494acee052be19 /src/lib/Bcfg2/Client/Tools/Pacman.py | |
| parent | be0e43af56fbd56dbb3f8d0266503e7b820f2c11 (diff) | |
| download | bcfg2-aeddf10f2e129c70b182e91b727ccc8028e3fd45.tar.gz bcfg2-aeddf10f2e129c70b182e91b727ccc8028e3fd45.tar.bz2 bcfg2-aeddf10f2e129c70b182e91b727ccc8028e3fd45.zip | |
made full pylint checks the default, expanded pylint coverage to lots of tools
Diffstat (limited to 'src/lib/Bcfg2/Client/Tools/Pacman.py')
| -rw-r--r-- | src/lib/Bcfg2/Client/Tools/Pacman.py | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/lib/Bcfg2/Client/Tools/Pacman.py b/src/lib/Bcfg2/Client/Tools/Pacman.py index 02889a2e7..75dd62ede 100644 --- a/src/lib/Bcfg2/Client/Tools/Pacman.py +++ b/src/lib/Bcfg2/Client/Tools/Pacman.py @@ -28,7 +28,7 @@ class Pacman(Bcfg2.Client.Tools.PkgTool): #self.logger.info(" pkgname: %s, version: %s" % (pkgname, version)) self.installed[pkgname] = version - def VerifyPackage(self, entry, modlist): + def VerifyPackage(self, entry, _): '''Verify Package status for entry''' self.logger.info("VerifyPackage : %s : %s" % entry.get('name'), @@ -42,7 +42,8 @@ class Pacman(Bcfg2.Client.Tools.PkgTool): if entry.attrib['name'] in self.installed: if entry.attrib['version'] == 'auto': return True - elif self.installed[entry.attrib['name']] == entry.attrib['version']: + elif self.installed[entry.attrib['name']] == \ + entry.attrib['version']: #if not self.setup['quick'] and \ # entry.get('verify', 'true') == 'true': #FIXME: need to figure out if pacman @@ -79,6 +80,6 @@ class Pacman(Bcfg2.Client.Tools.PkgTool): try: self.logger.debug("Running : %s -S %s" % (self.pkgtool, pkgline)) self.cmd.run("%s -S %s" % (self.pkgtool, pkgline)) - except Exception: - e = sys.exc_info()[1] - self.logger.error("Error occurred during installation: %s" % e) + except: # pylint: disable=W0702 + err = sys.exc_info()[1] + self.logger.error("Error occurred during installation: %s" % err) |