summaryrefslogtreecommitdiffstats
path: root/src/lib/Bcfg2/Client/XML.py
diff options
context:
space:
mode:
authorChris St. Pierre <chris.a.st.pierre@gmail.com>2012-09-25 11:49:15 -0400
committerChris St. Pierre <chris.a.st.pierre@gmail.com>2012-09-25 11:58:48 -0400
commiteac71fc1109f2edc6b71e62a6cff38d762bebe63 (patch)
tree203cf372e31b92dfc0cf7ea57c451c44e5e1e54b /src/lib/Bcfg2/Client/XML.py
parent3f16355e18cdceb37828a00a8181d9cc60815cd0 (diff)
downloadbcfg2-eac71fc1109f2edc6b71e62a6cff38d762bebe63.tar.gz
bcfg2-eac71fc1109f2edc6b71e62a6cff38d762bebe63.tar.bz2
bcfg2-eac71fc1109f2edc6b71e62a6cff38d762bebe63.zip
expanded pylint coverage
Diffstat (limited to 'src/lib/Bcfg2/Client/XML.py')
-rw-r--r--src/lib/Bcfg2/Client/XML.py17
1 files changed, 11 insertions, 6 deletions
diff --git a/src/lib/Bcfg2/Client/XML.py b/src/lib/Bcfg2/Client/XML.py
index d6bbd3b72..720416724 100644
--- a/src/lib/Bcfg2/Client/XML.py
+++ b/src/lib/Bcfg2/Client/XML.py
@@ -2,7 +2,7 @@
# library will use lxml, then builtin xml.etree, then ElementTree
-# pylint: disable=F0401,E0611
+# pylint: disable=F0401,E0611,W0611,W0613,C0103
try:
from lxml.etree import Element, SubElement, XML, tostring
@@ -16,8 +16,11 @@ except ImportError:
Element = xml.etree.ElementTree.Element
SubElement = xml.etree.ElementTree.SubElement
XML = xml.etree.ElementTree.XML
- def tostring(e, encoding=None, xml_declaration=None):
- return xml.etree.ElementTree.tostring(e, encoding=encoding)
+
+ def tostring(el, encoding=None, xml_declaration=None):
+ """ tostring implementation compatible with lxml """
+ return xml.etree.ElementTree.tostring(el, encoding=encoding)
+
driver = 'etree-py'
except ImportError:
try:
@@ -28,10 +31,12 @@ except ImportError:
Element = elementtree.ElementTree.Element
SubElement = elementtree.ElementTree.SubElement
XML = elementtree.ElementTree.XML
- def tostring(e, encoding=None, xml_declaration=None):
- return elementtree.ElementTree.tostring(e)
+
+ def tostring(el, encoding=None, xml_declaration=None):
+ """ tostring implementation compatible with lxml """
+ return elementtree.ElementTree.tostring(el)
except ImportError:
- print("Failed to load lxml, xml.etree and elementtree.ElementTree")
+ print("Failed to load lxml, xml.etree or elementtree.ElementTree")
print("Cannot continue")
raise SystemExit(1)