summaryrefslogtreecommitdiffstats
path: root/src/lib/Bcfg2/Server/Lint/InfoXML.py
diff options
context:
space:
mode:
authorChris St. Pierre <chris.a.st.pierre@gmail.com>2012-09-24 13:07:15 -0400
committerChris St. Pierre <chris.a.st.pierre@gmail.com>2012-09-25 11:58:47 -0400
commit6d4d8df68717780239fad273dd722359db10e64b (patch)
treec50c94430a417cab3c97084022d85332065b022b /src/lib/Bcfg2/Server/Lint/InfoXML.py
parentdd28e90f183972cc2a395094ce3e3f72e861953f (diff)
downloadbcfg2-6d4d8df68717780239fad273dd722359db10e64b.tar.gz
bcfg2-6d4d8df68717780239fad273dd722359db10e64b.tar.bz2
bcfg2-6d4d8df68717780239fad273dd722359db10e64b.zip
expanded pylint tests
Diffstat (limited to 'src/lib/Bcfg2/Server/Lint/InfoXML.py')
-rw-r--r--src/lib/Bcfg2/Server/Lint/InfoXML.py18
1 files changed, 11 insertions, 7 deletions
diff --git a/src/lib/Bcfg2/Server/Lint/InfoXML.py b/src/lib/Bcfg2/Server/Lint/InfoXML.py
index 5e4e21e18..e34f387ff 100644
--- a/src/lib/Bcfg2/Server/Lint/InfoXML.py
+++ b/src/lib/Bcfg2/Server/Lint/InfoXML.py
@@ -1,9 +1,12 @@
+""" ensure that all config files have an info.xml file"""
+
import os
import Bcfg2.Options
import Bcfg2.Server.Lint
from Bcfg2.Server.Plugins.Cfg.CfgInfoXML import CfgInfoXML
from Bcfg2.Server.Plugins.Cfg.CfgLegacyInfo import CfgLegacyInfo
+
class InfoXML(Bcfg2.Server.Lint.ServerPlugin):
""" ensure that all config files have an info.xml file"""
def Run(self):
@@ -34,13 +37,14 @@ class InfoXML(Bcfg2.Server.Lint.ServerPlugin):
@classmethod
def Errors(cls):
- return {"no-infoxml":"warning",
- "deprecated-info-file":"warning",
- "paranoid-false":"warning",
- "broken-xinclude-chain":"warning",
- "required-infoxml-attrs-missing":"error"}
+ return {"no-infoxml": "warning",
+ "deprecated-info-file": "warning",
+ "paranoid-false": "warning",
+ "broken-xinclude-chain": "warning",
+ "required-infoxml-attrs-missing": "error"}
def check_infoxml(self, fname, xdata):
+ """ verify that info.xml contains everything it should """
for info in xdata.getroottree().findall("//Info"):
required = []
if "required_attrs" in self.config:
@@ -50,7 +54,8 @@ class InfoXML(Bcfg2.Server.Lint.ServerPlugin):
if missing:
self.LintError("required-infoxml-attrs-missing",
"Required attribute(s) %s not found in %s:%s" %
- (",".join(missing), fname, self.RenderXML(info)))
+ (",".join(missing), fname,
+ self.RenderXML(info)))
if ((Bcfg2.Options.MDATA_PARANOID.value and
info.get("paranoid") is not None and
@@ -61,4 +66,3 @@ class InfoXML(Bcfg2.Server.Lint.ServerPlugin):
self.LintError("paranoid-false",
"Paranoid must be true in %s:%s" %
(fname, self.RenderXML(info)))
-