Handle FAM monitor failures more gracefully:

* Where possible, create the file or directory that is about to be
  monitored.  This ensures that content can be added later without
  need to restart Bcfg2.  (Otherwise, adding the monitor would fail,
  and so when you did create the file in question, bcfg2-server would
  never be notified of it.)
* When not possible, give better error messages.

1 files changed, 14 insertions, 2 deletions

diff --git a/src/lib/Bcfg2/Server/Plugin/base.py b/src/lib/Bcfg2/Server/Plugin/base.py
index f7bc08717..ecd970b54 100644
--- a/src/lib/Bcfg2/Server/Plugin/base.py
+++ b/src/lib/Bcfg2/Server/Plugin/base.py
@@ -97,15 +97,21 @@ class Plugin(Debuggable):
         :param datastore: The path to the Bcfg2 repository on the
                           filesystem
         :type datastore: string
-        :raises: :class:`Bcfg2.Server.Plugin.exceptions.PluginInitError`
+        :raises: :exc:`OSError` if adding a file monitor failed;
+                 :class:`Bcfg2.Server.Plugin.exceptions.PluginInitError`
+                 on other errors
 
         .. autoattribute:: Bcfg2.Server.Plugin.base.Debuggable.__rmi__
         """
+        Debuggable.__init__(self, name=self.name)
         self.Entries = {}
         self.core = core
         self.data = os.path.join(datastore, self.name)
+        if not os.path.exists(self.data):
+            self.logger.warning("%s: %s does not exist, creating" %
+                                (self.name, self.data))
+            os.makedirs(self.data)
         self.running = True
-        Debuggable.__init__(self, name=self.name)
 
     @classmethod
     def init_repo(cls, repo):
@@ -125,5 +131,11 @@ class Plugin(Debuggable):
         self.debug_log("Shutting down %s plugin" % self.name)
         self.running = False
 
+    def set_debug(self, debug):
+        for entry in self.Entries.values():
+            if isinstance(entry, Debuggable):
+                entry.set_debug(debug)
+        return Debuggable.set_debug(self, debug)
+
     def __str__(self):
         return "%s Plugin" % self.__class__.__name__