diff options
| author | Chris St. Pierre <chris.a.st.pierre@gmail.com> | 2012-09-27 14:33:34 -0400 |
|---|---|---|
| committer | Chris St. Pierre <chris.a.st.pierre@gmail.com> | 2012-09-27 14:33:34 -0400 |
| commit | 1bdb14055dd1b2395047793ee28c17bbae65c845 (patch) | |
| tree | 2224d9de85871f936f8f63582ab349df0ecfdc6c /src/lib/Bcfg2/Server/Plugins/Properties.py | |
| parent | 40d74d9a4bcca2452def08a0890c08fdca864d4c (diff) | |
| download | bcfg2-1bdb14055dd1b2395047793ee28c17bbae65c845.tar.gz bcfg2-1bdb14055dd1b2395047793ee28c17bbae65c845.tar.bz2 bcfg2-1bdb14055dd1b2395047793ee28c17bbae65c845.zip | |
wrote unit tests for Properties
Diffstat (limited to 'src/lib/Bcfg2/Server/Plugins/Properties.py')
| -rw-r--r-- | src/lib/Bcfg2/Server/Plugins/Properties.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/lib/Bcfg2/Server/Plugins/Properties.py b/src/lib/Bcfg2/Server/Plugins/Properties.py index 1d5bdbcfc..d9e622645 100644 --- a/src/lib/Bcfg2/Server/Plugins/Properties.py +++ b/src/lib/Bcfg2/Server/Plugins/Properties.py @@ -41,8 +41,7 @@ class PropertyFile(Bcfg2.Server.Plugin.StructFile): raise PluginExecutionError(msg) try: - open(self.name, - "wb").write( + open(self.name, "wb").write( lxml.etree.tostring(self.xdata, xml_declaration=False, pretty_print=True).decode('UTF-8')) @@ -60,7 +59,7 @@ class PropertyFile(Bcfg2.Server.Plugin.StructFile): if os.path.exists(schemafile): try: schema = lxml.etree.XMLSchema(file=schemafile) - except: + except lxml.etree.XMLSchemaParseError: err = sys.exc_info()[1] raise PluginExecutionError("Failed to process schema for %s: " "%s" % (self.name, err)) @@ -105,6 +104,8 @@ class PropertyFile(Bcfg2.Server.Plugin.StructFile): # error is raised below pass except KeyError: + # bruteforce_decrypt raises an EVPError with a sensible + # error message, so we just let it propagate up the stack return bruteforce_decrypt(element.text, passphrases=passes.values(), algorithm=get_algorithm(SETUP)) |