web_reports: added a view to show the most common configuration problems

6 files changed, 119 insertions, 2 deletions

diff --git a/src/lib/Bcfg2/Server/Reports/reports/models.py b/src/lib/Bcfg2/Server/Reports/reports/models.py
index 7540dae66..54ad2fcf0 100644
--- a/src/lib/Bcfg2/Server/Reports/reports/models.py
+++ b/src/lib/Bcfg2/Server/Reports/reports/models.py
@@ -275,6 +275,24 @@ class Reason(models.Model):
     def _str_(self):
         return "Reason"
 
+    def short_list(self):
+        rv = []
+        if self.current_owner or self.current_group or self.current_perms:
+            rv.append("File permissions")
+        if self.current_status:
+            rv.append("Incorrect status")
+        if self.current_to:
+            rv.append("Incorrect target")
+        if self.current_version or self.version == 'auto':
+            rv.append("Wrong version")
+        if not self.current_exists:
+            rv.append("Missing")
+        if self.current_diff or self.is_sensitive:
+            rv.append("Incorrect data")
+        if self.unpruned:
+            rv.append("Directory has extra files")
+        return rv
+
     @staticmethod
     @transaction.commit_on_success
     def prune_orphans():
diff --git a/src/lib/Bcfg2/Server/Reports/reports/templates/base-timeview.html b/src/lib/Bcfg2/Server/Reports/reports/templates/base-timeview.html
index 842de36f0..9a5ef651c 100644
--- a/src/lib/Bcfg2/Server/Reports/reports/templates/base-timeview.html
+++ b/src/lib/Bcfg2/Server/Reports/reports/templates/base-timeview.html
@@ -20,6 +20,9 @@ document.write(getCalendarStyles());
 {% if not timestamp %}Rendered at {% now "Y-m-d H:i" %} | {% else %}View as of {{ timestamp|date:"Y-m-d H:i" }} | {% endif %}{% spaceless %}
   <a id='cal_link' name='cal_link' href='#' onclick='showCalendar(); return false;'
       >[change]</a>
-  <form method='post' action='{{ path }}' id='cal_form' name='cal_form'><input id='cal_date' name='cal_date' type='hidden' value=''/></form>
+  <form method='post' action='{{ path }}' id='cal_form' name='cal_form'>
+    <input id='cal_date' name='cal_date' type='hidden' value=''/>
+    <input name='op' type='hidden' value='timeview'/>
+  </form>
 {% endspaceless %}
 {% endblock %}
diff --git a/src/lib/Bcfg2/Server/Reports/reports/templates/base.html b/src/lib/Bcfg2/Server/Reports/reports/templates/base.html
index f541c0d2b..625177390 100644
--- a/src/lib/Bcfg2/Server/Reports/reports/templates/base.html
+++ b/src/lib/Bcfg2/Server/Reports/reports/templates/base.html
@@ -62,6 +62,7 @@
       <li>Entries Configured</li>
     </ul>
     <ul class='menu-level2'>
+      <li><a href="{% url reports_common_problems %}">Common problems</a></li>
       <li><a href="{% url reports_item_list "bad" %}">Bad</a></li>
       <li><a href="{% url reports_item_list "modified" %}">Modified</a></li>
       <li><a href="{% url reports_item_list "extra" %}">Extra</a></li>
diff --git a/src/lib/Bcfg2/Server/Reports/reports/templates/config_items/common.html b/src/lib/Bcfg2/Server/Reports/reports/templates/config_items/common.html
new file mode 100644
index 000000000..02e53cff5
--- /dev/null
+++ b/src/lib/Bcfg2/Server/Reports/reports/templates/config_items/common.html
@@ -0,0 +1,42 @@
+{% extends "base-timeview.html" %}
+{% load bcfg2_tags %}
+
+{% block title %}Bcfg2 - Common Problems{% endblock %}
+
+{% block extra_header_info %}
+{% endblock%}
+
+{% block pagebanner %}Common configuration problems{% endblock %}
+
+{% block content %}
+  <div id='threshold_box'>
+    <form method='post' action='{{ request.path }}'>
+    <span>Showing items with more then {{ threshold }} entries</span>
+    <input type='text' name='threshold' value='{{ threshold }}' maxlength='5' size='5' />
+    <input type='submit' value='Change' />
+    </form>
+  </div>
+  {% for type_name, type_list in lists %}
+    <div class='entry_list'>
+      <div class='entry_list_head element_list_head' onclick='javascript:toggleMe("table_{{ type_name }}");'>
+        <h3>{{ type_name|capfirst }} entries</h3>
+        <div class='entry_expand_tab' id='plusminus_table_{{ type_name }}'>[&ndash;]</div>
+      </div>
+    {% if type_list %}
+      <table id='table_{{ type_name }}' class='entry_list'>
+      <tr style='text-align: left'><th>Type</th><th>Name</th><th>Count</th><th>Reason</th></tr>
+      {% for entry, reason, interaction in type_list %}
+        <tr class='{% cycle listview,listview_alt %}'>
+          <td>{{ entry.kind }}</td>
+          <td><a href="{% url reports_item type=type_name pk=interaction.0 %}">{{ entry.name }}</a></td>
+          <td>{{ interaction|length }}</td>
+          <td>{{ reason.short_list|join:"," }}</td>
+        </tr>
+      {% endfor %}
+      </table>
+    {% else %}
+    <p>There are currently no inconsistent {{ type_name }} configuration entries.</p>
+    {% endif %}
+    </div>
+  {% endfor %}
+{% endblock %}
diff --git a/src/lib/Bcfg2/Server/Reports/reports/urls.py b/src/lib/Bcfg2/Server/Reports/reports/urls.py
index 434ce07b7..c7255101f 100644
--- a/src/lib/Bcfg2/Server/Reports/reports/urls.py
+++ b/src/lib/Bcfg2/Server/Reports/reports/urls.py
@@ -25,6 +25,8 @@ urlpatterns += patterns('Bcfg2.Server.Reports.reports',
         (r'^summary/?$', 'views.display_summary', None, 'reports_summary'),
         (r'^timing/?$', 'views.display_timing', None, 'reports_timing'),
         (r'^elements/(?P<type>\w+)/?$', 'views.config_item_list', None, 'reports_item_list'),
+        (r'^common/(?P<threshold>\d+)/?$', 'views.common_problems', None, 'reports_common_problems'),
+        (r'^common/?$', 'views.common_problems', None, 'reports_common_problems'),
 ))
 
 urlpatterns += patterns('Bcfg2.Server.Reports.reports',
diff --git a/src/lib/Bcfg2/Server/Reports/reports/views.py b/src/lib/Bcfg2/Server/Reports/reports/views.py
index 02d633a5e..38a219167 100644
--- a/src/lib/Bcfg2/Server/Reports/reports/views.py
+++ b/src/lib/Bcfg2/Server/Reports/reports/views.py
@@ -47,7 +47,7 @@ def timeview(fn):
     """
     def _handle_timeview(request, **kwargs):
         """Send any posts back."""
-        if request.method == 'POST':
+        if request.method == 'POST' and request.POST.get('op', '') == 'timeview':
             cal_date = request.POST['cal_date']
             try:
                 fmt = "%Y/%m/%d"
@@ -155,6 +155,57 @@ def config_item_list(request, type, timestamp=None):
 
 
 @timeview
+def common_problems(request, timestamp=None, threshold=None):
+    """Mine config entries"""
+
+    if request.method == 'POST':
+        try:
+            threshold = int(request.POST['threshold'])
+            view, args, kw = resolve(request.META['PATH_INFO'])
+            kw['threshold'] = threshold
+            return HttpResponseRedirect(reverse(view,
+                                                args=args,
+                                                kwargs=kw))
+        except:
+            pass
+
+    try:
+        threshold = int(threshold)
+    except:
+        threshold = 10
+
+    c_intr = Interaction.objects.get_interaction_per_client_ids(timestamp)
+    data_list = { 1: {}, 2: {}, 3: {}}
+    ldata = list(Entries_interactions.objects.filter(
+            interaction__in=c_intr).values())
+
+    entry_ids = set([x['entry_id'] for x in ldata])
+    reason_ids = set([x['reason_id'] for x in ldata])
+    for x in ldata:
+        type = x['type']
+        data_key = (x['entry_id'], x['reason_id'])
+        try:
+            data_list[type][data_key].append(x['id'])
+        except KeyError:
+            data_list[type][data_key] = [x['id']]
+    
+    entries = Entries.objects.in_bulk(entry_ids)
+    reasons = Reason.objects.in_bulk(reason_ids)
+
+    lists = []
+    for type, type_name in TYPE_CHOICES:
+        lists.append([type_name.lower(), [(entries[e[0][0]], reasons[e[0][1]], e[1])
+            for e in sorted(data_list[type].items(), key=lambda x: len(x[1]), reverse=True)
+            if len(e[1]) > threshold]])
+
+    return render_to_response('config_items/common.html',
+                              {'lists': lists,
+                               'timestamp': timestamp,
+                               'threshold': threshold},
+        context_instance=RequestContext(request))
+
+
+@timeview
 def client_index(request, timestamp=None):
     """
     Render a grid view of active clients.