summaryrefslogtreecommitdiffstats
path: root/src/lib/Server/Plugin.py
diff options
context:
space:
mode:
authorSol Jerome <sol.jerome@gmail.com>2011-05-11 15:24:26 -0500
committerSol Jerome <sol.jerome@gmail.com>2011-06-14 12:36:45 -0500
commit32659c415a2c438eaa2dbf160d118465439da6dd (patch)
tree9b7e902d63a914661d9945a640493ffdacf45060 /src/lib/Server/Plugin.py
parenta408e7cbe36beacc2aefe291ac3f5caec36ddf35 (diff)
downloadbcfg2-32659c415a2c438eaa2dbf160d118465439da6dd.tar.gz
bcfg2-32659c415a2c438eaa2dbf160d118465439da6dd.tar.bz2
bcfg2-32659c415a2c438eaa2dbf160d118465439da6dd.zip
Plugin: Fix nasty list comprehension bug
It appears as though Python 2 kept around variables assigned within a list comprehensions which caused this to go unnoticed. Signed-off-by: Sol Jerome <sol.jerome@gmail.com>
Diffstat (limited to 'src/lib/Server/Plugin.py')
-rw-r--r--src/lib/Server/Plugin.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/Server/Plugin.py b/src/lib/Server/Plugin.py
index cd2b63656..3b331b300 100644
--- a/src/lib/Server/Plugin.py
+++ b/src/lib/Server/Plugin.py
@@ -644,9 +644,9 @@ class PrioDir(Plugin, Generator, XMLDirectoryBacked):
def BindEntry(self, entry, metadata):
"""Check package lists of package entries."""
- [src.Cache(metadata) for src in list(self.entries.values())]
name = entry.get('name')
- if not src.cache:
+ if False in [src.Cache(metadata) for src in
+ list(self.entries.values())]:
self.logger.error("Called before data loaded")
raise PluginExecutionError
matching = [src for src in list(self.entries.values())