diff options
| author | Mike McCallister <mike@mccllstr.com> | 2011-10-15 22:06:31 -0500 |
|---|---|---|
| committer | Mike McCallister <mike@mccllstr.com> | 2011-10-15 23:41:21 -0500 |
| commit | 826f385767ccf9f608fcfbe35e381a9dbc59db4b (patch) | |
| tree | 2320daecca65d435d78e37f4fd213cd41119a07a /src/lib/Server/Plugins/Packages/Apt.py | |
| parent | 17a031da6ec2ee448ee3d8e18dde5c6a3785c464 (diff) | |
| download | bcfg2-826f385767ccf9f608fcfbe35e381a9dbc59db4b.tar.gz bcfg2-826f385767ccf9f608fcfbe35e381a9dbc59db4b.tar.bz2 bcfg2-826f385767ccf9f608fcfbe35e381a9dbc59db4b.zip | |
Improve error handling of Packages plugin.
Provide a descriptive error message that avoids logging a traceback.
Error out (instead of continuing) upon receiving an HTTP error or an
indication that the URL is malformed.
Only write data to the cache file if it was successfully retrieved
from the URL.
Make log messages for Packages plugin use consistent "Packages:" prefix.
Diffstat (limited to 'src/lib/Server/Plugins/Packages/Apt.py')
| -rw-r--r-- | src/lib/Server/Plugins/Packages/Apt.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/Server/Plugins/Packages/Apt.py b/src/lib/Server/Plugins/Packages/Apt.py index ad3ebcabd..ed954af3b 100644 --- a/src/lib/Server/Plugins/Packages/Apt.py +++ b/src/lib/Server/Plugins/Packages/Apt.py @@ -9,7 +9,7 @@ logger = logging.getLogger("Packages") class AptCollection(Collection): def get_group(self, group): - self.logger.warning("Package groups are not supported by APT") + self.logger.warning("Packages: Package groups are not supported by APT") return [] class AptSource(Source): @@ -72,7 +72,7 @@ class AptSource(Source): try: reader = gzip.GzipFile(fname) except: - logger.error("Failed to read file %s" % fname) + logger.error("Packages: Failed to read file %s" % fname) raise for line in reader.readlines(): words = str(line.strip()).split(':', 1) |