summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSol Jerome <sol.jerome@gmail.com>2011-05-11 15:24:26 -0500
committerSol Jerome <sol.jerome@gmail.com>2011-05-11 15:24:26 -0500
commitea8cfddc7a5f494efde34092ccc2cd6880d2009a (patch)
treedc542ad46d70ebe836515b0b684ce96205e835be /src
parent7a03a93da1701fd14a7c7195b01557ba3e6b24c5 (diff)
downloadbcfg2-ea8cfddc7a5f494efde34092ccc2cd6880d2009a.tar.gz
bcfg2-ea8cfddc7a5f494efde34092ccc2cd6880d2009a.tar.bz2
bcfg2-ea8cfddc7a5f494efde34092ccc2cd6880d2009a.zip
Plugin: Fix nasty list comprehension bug
It appears as though Python 2 kept around variables assigned within a list comprehensions which caused this to go unnoticed. Signed-off-by: Sol Jerome <sol.jerome@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/lib/Server/Plugin.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/Server/Plugin.py b/src/lib/Server/Plugin.py
index cd2b63656..3b331b300 100644
--- a/src/lib/Server/Plugin.py
+++ b/src/lib/Server/Plugin.py
@@ -644,9 +644,9 @@ class PrioDir(Plugin, Generator, XMLDirectoryBacked):
def BindEntry(self, entry, metadata):
"""Check package lists of package entries."""
- [src.Cache(metadata) for src in list(self.entries.values())]
name = entry.get('name')
- if not src.cache:
+ if False in [src.Cache(metadata) for src in
+ list(self.entries.values())]:
self.logger.error("Called before data loaded")
raise PluginExecutionError
matching = [src for src in list(self.entries.values())