summaryrefslogtreecommitdiffstats
path: root/src/lib/Bcfg2
Commit message (Collapse)AuthorAgeFilesLines
...
* | Don't parse unicode XML with encodingChris St. Pierre2014-01-221-1/+10
| | | | | | | | | | Fix another place where a unicode XML string with an encoding declaration may be read. Cf. 0f8d403d1a86cfbfe8222662dc445e16e8f7eff9
* | POSIX: Properly stringify ACLs with no user/group specifiedChris St. Pierre2014-01-161-1/+4
| | | | | | | | | | | | | | This is just a workaround to avoid a traceback; the real fix will involve making the POSIX tool properly handle ACLs with no user/group given, which refer to the current user/group of the file they apply to.
* | FAM: Get full traceback when event handling errorsChris St. Pierre2014-01-161-1/+2
| |
* | Reporting: occasionally reap child threadsMichael Fenn2014-01-101-0/+23
| | | | | | | | | | | | | | | | I noticed that, at least on Python 2.4, memory for threads doesn't get freed until the threads are joined. This patch causes the collector to periodically go through and reap those threads. Tested in production for ~1 month, no reported issues.
* | Encryption: fixed base64 decode failure messageChris St. Pierre2014-01-071-1/+1
| |
* | fixed indentation in previousRichard Connon2014-01-051-1/+1
| |
* | Fixed syntatical error in previousRichard Connon2014-01-051-2/+2
| |
* | Fixed group blacklist issue #150Richard Connon2014-01-051-0/+1
| |
* | Encryption: better error message when base64 decode failsChris St. Pierre2014-01-021-1/+10
| |
* | bcfg2-lint: expand wildcard xincludes when validating XMLChris St. Pierre2013-12-311-0/+29
| |
* | Augeas improvements:Chris St. Pierre2013-12-111-10/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | * Added ability to specify initial content for a file that doesn't exist, to avoid a messy situation where you'd have to probe for file existence and either use a Path type="file" or Path type="augeas" depending, and run Bcfg2 twice. * All commands in an Augeas path are run if *any* of them fail to verify. Previously, only commands that hadn't been run would be installed, but that had issues, particularly with the Clear command, which could pass verification but then be required during the installation phase anyway. * Miscellaneous bug fixes.
* | bcfg2-lint: New ValidateJSON pluginChris St. Pierre2013-12-091-0/+70
| | | | | | | | | | This plugin validates the JSON files that can be used by Properties and Ohai.
* | bcfg2-lint: New TemplateAbuse plugin detects templated scriptsChris St. Pierre2013-12-091-0/+75
| | | | | | | | | | | | | | | | TemplateAbuse detects templated scripts (either files that end with a known extension, or that start with a shebang line) and executables (based off of their permissions in info.xml) and warns about them, since templating scripts is dicey at best, and almost always better done by templating a config file for the script to read instead.
* | XMLSrc: Load XML in one step instead of separate read and parseChris St. Pierre2013-12-091-9/+2
| |
* | Cfg: let EncryptedGenerator load setup object whenever the plugin is importedChris St. Pierre2013-12-091-3/+6
| | | | | | | | | | | | | | Previously, if CfgEncryptedGenerator was imported before the Cfg object was instantiated, it would finalize the Bcfg2.Server.Plugins.Cfg.SETUP object with a value of None, and would be unable to access the options dict.
* | Probes: fixed default list of allowed probe groupsChris St. Pierre2013-12-061-1/+1
| |
* | Augeas: avoid deprecation warningChris St. Pierre2013-12-051-2/+2
| |
* | Augeas: Added docstrings, fixed some minor pylint issuesChris St. Pierre2013-12-051-20/+91
| |
* | Augeas: Only install unverified commandsChris St. Pierre2013-12-051-0/+2
| |
* | POSIX: skip loading POSIX sub-tools that raise ImportErrorChris St. Pierre2013-12-051-2/+5
| | | | | | | | This mimics the behavior for "real" tools
* | Encryption: fixed unit testsChris St. Pierre2013-12-051-4/+4
| |
* | Tools: new Augeas driverChris St. Pierre2013-12-051-0/+211
| |
* | testsuite: fixed unit tests for database fixesChris St. Pierre2013-11-251-4/+5
| |
* | Core: Avoid starting server if database is enabled but cannot be usedChris St. Pierre2013-11-252-8/+17
| | | | | | | | | | | | | | Plugins that use the database often act quite differently depending on whether or not the database is enabled. If we start the server without the database (e.g., the connection failed), then Very Strange Things can happen.
* | bcfg2-admin: added missing docstringChris St. Pierre2013-11-251-1/+2
| |
* | bcfg2-admin: Restored missing "bcfg2-admin client add ... attrib=val" ↵Chris St. Pierre2013-11-252-3/+25
| | | | | | | | functionality
* | Bundler: Fix parsing XML template output with encoding declarationChris St. Pierre2013-11-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | lxml 3.2.1 complains when you try to parse a unicode (in Python 2) or string (in Python 3) containing an XML document with an encoding declaration. Traceback: ValueError: Unicode strings with encoding declaration are not supported. Please use bytes input or XML fragments without declaration. This encodes the document as a string (in Python 2) or bytes (in Python 3) to avoid the lxml error. There may be other places this happens, too, although in most other cases we should use lxml.etree.parse() to parse a file, or we parse strings (in Python 2) instead of unicode objects.
* | bcfg2-lint: resolve XIncludes when parsing XML for validationChris St. Pierre2013-11-181-3/+12
| |
* | Reporting: Remove wildcard importsSol Jerome2013-11-163-6/+3
| | | | | | | | Signed-off-by: Sol Jerome <sol.jerome@gmail.com>
* | Probes: added missing docstringChris St. Pierre2013-11-141-0/+3
| |
* | testsuite: fixed unit tests for Probes allowed_groups optionChris St. Pierre2013-11-142-2/+4
| |
* | Add probes.allowed_groups option to restrict group assignments.Simon Ruderich2013-11-142-2/+25
| |
* | Options: make "public" default pgsql database schemaChris St. Pierre2013-11-131-1/+1
| |
* | Reports: Add missing ImportErrorSol Jerome2013-11-111-1/+1
| | | | | | | | Signed-off-by: Sol Jerome <sol.jerome@gmail.com>
* | Fix compatibility with Django 1.6.Simon Ruderich2013-11-118-12/+32
| |
* | Probes: automatically remove duplicate probe dataChris St. Pierre2013-11-111-3/+10
| |
* | Version bump to 1.3.3v1.3.3Sol Jerome2013-11-072-2/+2
| | | | | | | | Signed-off-by: Sol Jerome <sol.jerome@gmail.com>
* | Multiprocessing: removed unused importChris St. Pierre2013-11-061-1/+1
| |
* | Multiprocessing: don't reuse child RPC listenersChris St. Pierre2013-11-051-26/+7
| |
* | Merge pull request #143 from fennm/proxy-retry-on-ssl-errorChris St. Pierre2013-11-051-1/+0
|\ \ | | | | | | Proxy: Catch SSL errors and retry
| * | Don't re-raise unknown exceptions per stpierreMichael Fenn2013-11-021-4/+0
| | |
| * | Proxy: Catch SSL errors and retryMichael Fenn2013-11-011-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The SSL library can throw an exception during the XMLRPC method call. There is no explicit except statement for this type of exception so they get raised up and abort the client's processing. This patch catches the exception so that normal retry processing occurs. Typical traceback: Traceback (most recent call last): File "/usr/sbin/bcfg2", line 29, in ? sys.exit(main()) File "/usr/sbin/bcfg2", line 26, in main return Client(setup).run() File "/usr/lib/python2.4/site-packages/Bcfg2/Client/Client.py", line 256, in run rawconfig = self.get_config(times=times).decode('utf-8') File "/usr/lib/python2.4/site-packages/Bcfg2/Client/Client.py", line 225, in get_config self.run_probes(times=times) File "/usr/lib/python2.4/site-packages/Bcfg2/Client/Client.py", line 151, in run_probes probes = Bcfg2.Client.XML.XML(str(self.proxy.GetProbes())) File "/usr/lib/python2.4/site-packages/Bcfg2/Proxy.py", line 81, in __call__ return _orig_Method.__call__(self, *args) File "/usr/lib64/python2.4/xmlrpclib.py", line 1096, in __call__ return self.__send(self.__name, args) File "/usr/lib64/python2.4/xmlrpclib.py", line 1383, in __request verbose=self.__verbose File "/usr/lib/python2.4/site-packages/Bcfg2/Proxy.py", line 331, in request return self.parse_response(response) File "/usr/lib64/python2.4/xmlrpclib.py", line 1255, in parse_response return self._parse_response(file, None) File "/usr/lib64/python2.4/xmlrpclib.py", line 1276, in _parse_response response = file.read(1024) File "/usr/lib64/python2.4/httplib.py", line 480, in read s = self.fp.read(amt) File "/usr/lib64/python2.4/socket.py", line 303, in read data = self._sock.recv(recv_size) File "/usr/lib64/python2.4/site-packages/M2Crypto/SSL/Connection.py", line 217, in read return self._read_bio(size) File "/usr/lib64/python2.4/site-packages/M2Crypto/SSL/Connection.py", line 202, in _read_bio return m2.ssl_read(self.ssl, size, self._timeout) M2Crypto.SSL.SSLError: (104, 'Connection reset by peer')
* | | Admin: Don't call dead Mode.__call__ codeMichael Fenn2013-11-052-2/+0
|/ / | | | | | | | | | | | | | | | | In 9eb3db84, Bcfg2.Server.Admin.Mode.__call__() was changed from pass to raise a NotImplementedError. This causes bcfg2-admin compare and bcfg2-admin snapshots to fail because they call Bcfg2.Server.Admin.Mode.__call__() right away. Since that method didn't do anything anyway, it seems expediant to just avoid the call altogether.
* | Revert "Reporting: Simple sanity check to avoid creating too many threads"Michael Fenn2013-10-141-3/+0
| | | | | | | | | | | | | | | | This reverts commit f813f86f8ac2bc7b55f4eb6a0d936f1ce4f68ba7. Premature optimization is the root of all evil, etc. Conflicts: src/lib/Bcfg2/Reporting/Collector.py
* | Reporting: misc improvements to collector threadingMichael Fenn2013-10-101-4/+6
| | | | | | | | | | | | 1. Use a better convention for calling the threading.Thread constructor 2. Add docstring to ReportingStoreThread.run 3. Give the storage thread variable a better name
* | Merge remote-tracking branch 'upstream/maint' into ↵Michael Fenn2013-10-103-5/+8
|\ \ | | | | | | | | | reporting-thread-each-data-import
| * | Packages: fixed metadata.Packages["sources"]Chris St. Pierre2013-10-091-1/+1
| | |
| * | Metadata: read in clients.xml on every writeChris St. Pierre2013-10-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures consistency between the in-memory representation of clients.xml and the representation on disk. If we don't read our writes immediately, there's a race condition when creating a new client: If it asserts its profile or version before the FAM event from the clients.xml edit is processed, then the clients doesn't appear to exist yet, and Bcfg2 complains.
| * | Metadata: import any() from CompatChris St. Pierre2013-10-031-1/+3
| | |
| * | Core: Fixed error message on failed altsrc bindChris St. Pierre2013-09-301-3/+3
| | |