From 82cdfeba16096145c1fc8e6bd800760809e7f580 Mon Sep 17 00:00:00 2001 From: "Chris St. Pierre" Date: Mon, 9 Jan 2012 11:54:38 -0500 Subject: added bcfg2-lint plugin for GroupPatterns --- src/lib/Server/Lint/GroupPatterns.py | 31 +++++++++++++++++++++++++++++++ src/lib/Server/Lint/__init__.py | 5 +++-- 2 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 src/lib/Server/Lint/GroupPatterns.py diff --git a/src/lib/Server/Lint/GroupPatterns.py b/src/lib/Server/Lint/GroupPatterns.py new file mode 100644 index 000000000..b69d7a5d8 --- /dev/null +++ b/src/lib/Server/Lint/GroupPatterns.py @@ -0,0 +1,31 @@ +import sys +import Bcfg2.Server.Lint +from Bcfg2.Server.Plugins.GroupPatterns import PatternMap + +class GroupPatterns(Bcfg2.Server.Lint.ServerPlugin): + """ Check Genshi templates for syntax errors """ + + def Run(self): + """ run plugin """ + if 'GroupPatterns' in self.core.plugins: + cfg = self.core.plugins['GroupPatterns'].config + for entry in cfg.xdata.xpath('//GroupPattern'): + groups = [g.text for g in entry.findall('Group')] + self.check(entry, groups, ptype='NamePattern') + self.check(entry, groups, ptype='NameRange') + + def check(self, entry, groups, ptype="NamePattern"): + if ptype == "NamePattern": + pmap = lambda p: PatternMap(p, None, groups) + else: + pmap = lambda p: PatternMap(None, p, groups) + + for el in entry.findall(ptype): + pat = el.text + try: + pmap(pat) + except: + err = sys.exc_info()[1] + self.LintError("pattern-fails-to-initialize", + "Failed to initialize %s %s for %s: %s" % + (ptype, pat, entry.get('pattern'), err)) diff --git a/src/lib/Server/Lint/__init__.py b/src/lib/Server/Lint/__init__.py index f47059ac4..a9d57c46c 100644 --- a/src/lib/Server/Lint/__init__.py +++ b/src/lib/Server/Lint/__init__.py @@ -117,8 +117,9 @@ class ErrorHandler (object): "xml-failed-to-verify":"error", "merge-cfg":"warning", "merge-probes":"warning", - "input-output-error": "error", - "genshi-syntax-error": "error"} + "input-output-error":"error", + "genshi-syntax-error":"error", + "pattern-fails-to-initialize":"error"} def __init__(self, config=None): self.errors = 0 -- cgit v1.2.3-1-g7c22