From e2dc5f5a5fbc992c39d36693de552c275fef8f47 Mon Sep 17 00:00:00 2001 From: "Chris St. Pierre" Date: Thu, 28 Jul 2011 10:27:01 -0400 Subject: bcfg2-lint RequiredAttrs plugin checks for text content of "file" Paths --- src/lib/Server/Lint/RequiredAttrs.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/lib/Server/Lint/RequiredAttrs.py b/src/lib/Server/Lint/RequiredAttrs.py index cb69149b5..f1a50c13e 100644 --- a/src/lib/Server/Lint/RequiredAttrs.py +++ b/src/lib/Server/Lint/RequiredAttrs.py @@ -61,6 +61,13 @@ class RequiredAttrs(Bcfg2.Server.Lint.ServerPlugin): if dev_type in ['block', 'char']: # check if major/minor are specified required_attrs |= set(['major', 'minor']) + + if pathtype == 'file' and not entry.text: + self.LintError("required-attrs-missing", + "Text missing for %s %s in %s: %s" % + (entry.tag, pathname, filename, + self.RenderXML(entry))) + if not pathset.issuperset(required_attrs): self.LintError("required-attrs-missing", "The required attributes %s are missing for %s %sin %s:\n%s" % -- cgit v1.2.3-1-g7c22