From f35a435e51cd814f6985b48fab4bfb7ca043f5f9 Mon Sep 17 00:00:00 2001 From: Tim Laszlo Date: Wed, 17 Oct 2012 15:43:09 -0500 Subject: CfgLegacyInfo: Move the dict outside of the for loop --- src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'src/lib/Bcfg2/Server/Plugins/Cfg') diff --git a/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py b/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py index aedf579fc..7277d5d08 100644 --- a/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py +++ b/src/lib/Bcfg2/Server/Plugins/Cfg/CfgLegacyInfo.py @@ -33,6 +33,7 @@ class CfgLegacyInfo(CfgInfo): def handle_event(self, event): if event.code2str() == 'deleted': return + self.metadata = dict() for line in open(self.path).readlines(): match = Bcfg2.Server.Plugin.INFO_REGEX.match(line) if not match: @@ -40,11 +41,9 @@ class CfgLegacyInfo(CfgInfo): (event.filename, line)) continue else: - self.metadata = \ - dict([(key, value) - for key, value in list(match.groupdict().items()) - if value]) - if ('mode' in self.metadata and - len(self.metadata['mode']) == 3): - self.metadata['mode'] = "0%s" % self.metadata['mode'] + for key, value in list(match.groupdict().items()): + if value: + self.metadata[key] = value + if ('mode' in self.metadata and len(self.metadata['mode']) == 3): + self.metadata['mode'] = "0%s" % self.metadata['mode'] handle_event.__doc__ = CfgInfo.handle_event.__doc__ -- cgit v1.2.3-1-g7c22