From 89e7afbf74ffbbb54dd892bf2c4245aedee2a832 Mon Sep 17 00:00:00 2001 From: "Chris St. Pierre" Date: Tue, 9 Dec 2014 11:10:24 -0600 Subject: Remove blanket excepts from plugins and lint This removes most blanket except: clauses from all plugins, including the base plugin libraries, and bcfg2-lint. The few that remain should all be necessary. Most of the changes were quite minor, but this did require some restructuring of the CfgPrivateKeyCreator; as a result, the tests for that module were rewritten. --- src/lib/Bcfg2/Server/Plugins/Hg.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src/lib/Bcfg2/Server/Plugins/Hg.py') diff --git a/src/lib/Bcfg2/Server/Plugins/Hg.py b/src/lib/Bcfg2/Server/Plugins/Hg.py index 7554b4d52..3260908d8 100644 --- a/src/lib/Bcfg2/Server/Plugins/Hg.py +++ b/src/lib/Bcfg2/Server/Plugins/Hg.py @@ -1,5 +1,5 @@ -""" The Hg plugin provides a revision interface for Bcfg2 repos using -mercurial. """ +"""Revision interface for Bcfg2 repos using mercurial. +""" import sys from mercurial import ui, hg @@ -7,8 +7,9 @@ import Bcfg2.Server.Plugin class Hg(Bcfg2.Server.Plugin.Version): - """ The Hg plugin provides a revision interface for Bcfg2 repos - using mercurial. """ + """Revision interface for Bcfg2 repos using mercurial. + """ + __author__ = 'bcfg-dev@mcs.anl.gov' __vcs_metadata_path__ = ".hg" @@ -24,7 +25,7 @@ class Hg(Bcfg2.Server.Plugin.Version): repo = hg.repository(ui.ui(), repo_path) tip = repo.changelog.tip() return repo.changelog.rev(tip) - except: + except hg.error.RepoError: err = sys.exc_info()[1] msg = "Failed to read hg repository: %s" % err self.logger.error(msg) -- cgit v1.2.3-1-g7c22