From 1a9234d10ca90bb47cbf99a1fc54f126eabc35fa Mon Sep 17 00:00:00 2001 From: Narayan Desai Date: Mon, 16 Apr 2007 19:04:03 +0000 Subject: Handle garbled XMLRPC requests properly git-svn-id: https://svn.mcs.anl.gov/repos/bcfg/trunk/bcfg2@3044 ce84e21b-d406-0410-9b95-82705330c041 --- src/lib/Server/Component.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/lib') diff --git a/src/lib/Server/Component.py b/src/lib/Server/Component.py index 5aebbcbdc..fe4324b29 100644 --- a/src/lib/Server/Component.py +++ b/src/lib/Server/Component.py @@ -144,7 +144,13 @@ class Component(TLSServer, """Decode and dispatch XMLRPC requests. Overloaded to pass through client address information """ - rawparams, method = xmlrpclib.loads(data) + try: + rawparams, method = xmlrpclib.loads(data) + except: + self.logger.error("Failed to parse request from %s" \ + % (address[0])) + #open('/tmp/badreq', 'w').write(data) + return xmlrpclib.dumps(xmlrpclib.Fault(4, "Bad Request")) if len(rawparams) < 2: self.logger.error("No authentication included with request from %s" % address[0]) return xmlrpclib.dumps(xmlrpclib.Fault(2, "No Authentication Info")) -- cgit v1.2.3-1-g7c22