From ba6cda25f5e659efd33431fe136e18f906eabbae Mon Sep 17 00:00:00 2001 From: "Chris St. Pierre" Date: Fri, 13 Sep 2013 15:20:57 -0400 Subject: Encryption: better logging when passphrase for encrypting Properties cannot be determined --- src/lib/Bcfg2/Server/Encryption.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/lib/Bcfg2/Server/Encryption.py b/src/lib/Bcfg2/Server/Encryption.py index 6d6c82fab..f0f83c7e2 100755 --- a/src/lib/Bcfg2/Server/Encryption.py +++ b/src/lib/Bcfg2/Server/Encryption.py @@ -369,17 +369,20 @@ class PropertiesCryptoMixin(object): pname = element.get("encrypted") if pname in Bcfg2.Options.setup.passphrases: passphrase = Bcfg2.Options.setup.passphrases[pname] - elif self.passphrase: + else: if pname: self.logger.warning("Passphrase %s not found in %s, " "using passphrase given on command line" % (pname, Bcfg2.Options.setup.config)) - passphrase = self.passphrase - pname = self.pname - else: - raise PassphraseError("Multiple passphrases found in %s, " - "specify one on the command line with -p" % - Bcfg2.Options.setup.config) + if self.passphrase: + passphrase = self.passphrase + pname = self.pname + else: + self.logger.warning("No passphrase specified for %s element" % + element.tag) + raise PassphraseError("Multiple passphrases found in %s, " + "specify one on the command line with " + "-p" % Bcfg2.Options.setup.config) return (pname, passphrase) def _write(self, filename, data): -- cgit v1.2.3-1-g7c22