From f469b10a44ade1285c9f29f189d3b774f88bea76 Mon Sep 17 00:00:00 2001 From: Alexander Sulfrian Date: Thu, 30 Oct 2014 08:35:50 -0500 Subject: testsuite: Fix tools __init__.py unit test Signed-off-by: Sol Jerome --- testsuite/Testsrc/Testlib/TestClient/TestTools/Test_init.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'testsuite') diff --git a/testsuite/Testsrc/Testlib/TestClient/TestTools/Test_init.py b/testsuite/Testsrc/Testlib/TestClient/TestTools/Test_init.py index 390b92608..e0dacc1ce 100644 --- a/testsuite/Testsrc/Testlib/TestClient/TestTools/Test_init.py +++ b/testsuite/Testsrc/Testlib/TestClient/TestTools/Test_init.py @@ -36,6 +36,8 @@ class TestTool(Bcfg2TestCase): setup = MagicMock() if 'command_timeout' not in setup: setup['command_timeout'] = None + if 'decision' not in setup: + setup['decision'] = None execs = self.test_obj.__execs__ self.test_obj.__execs__ = [] rv = self.test_obj(logger, setup, config) -- cgit v1.2.3-1-g7c22 From 0bfc5a946a10712a5d82daa6ae0d1cd50fbb4ba8 Mon Sep 17 00:00:00 2001 From: Alexander Sulfrian Date: Mon, 10 Nov 2014 01:26:26 +0100 Subject: Client/Tools/APT: fix pylint errors, enable check Previously pep8/pylint checks were disable for the APT tool because there were to many errors. This fix the pylint errors and enables the code style checks. --- testsuite/Testsrc/test_code_checks.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'testsuite') diff --git a/testsuite/Testsrc/test_code_checks.py b/testsuite/Testsrc/test_code_checks.py index c368d40ce..d9f985104 100644 --- a/testsuite/Testsrc/test_code_checks.py +++ b/testsuite/Testsrc/test_code_checks.py @@ -35,6 +35,7 @@ contingent_checks = { "lib/Bcfg2/Server/Admin": ["Reports.py", "Syncdb.py"], "sbin": ["bcfg2-reports"]}, ("pyinotify",): {"lib/Bcfg2/Server/FileMonitor": ["Inotify.py"]}, + ("apt",): {"lib/Bcfg2/Client/Tools": ["APT.py"]}, ("yum",): {"lib/Bcfg2/Client/Tools": ["YUM.py"]}, ("genshi",): {"lib/Bcfg2/Server/Plugins/Cfg": ["CfgGenshiGenerator.py"]}, ("Cheetah",): {"lib/Bcfg2/Server/Plugins/Cfg": ["CfgCheetahGenerator.py"]}, @@ -66,7 +67,7 @@ error_checks = { # perform no checks at all on the listed files no_checks = { - "lib/Bcfg2/Client/Tools": ["APT.py", "RPM.py", "rpmtools.py"], + "lib/Bcfg2/Client/Tools": ["RPM.py", "rpmtools.py"], "lib/Bcfg2/Server": ["Snapshots", "Hostbase"], "lib/Bcfg2": ["manage.py"], "lib/Bcfg2/Server/Reports": ["manage.py"], -- cgit v1.2.3-1-g7c22