1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
|
""" ``bcfg2-lint`` plugin for :ref:`Pkgmgr
<server-plugins-generators-pkgmgr>` """
import os
import glob
import lxml.etree
import Bcfg2.Options
from Bcfg2.Server.Lint import ServerlessPlugin
class Pkgmgr(ServerlessPlugin):
""" Find duplicate :ref:`Pkgmgr
<server-plugins-generators-pkgmgr>` entries with the same
priority. """
def Run(self):
pset = set()
for pfile in glob.glob(os.path.join(Bcfg2.Options.setup.repository,
'Pkgmgr', '*.xml')):
if self.HandlesFile(pfile):
xdata = lxml.etree.parse(pfile).getroot()
# get priority, type, group
priority = xdata.get('priority')
ptype = xdata.get('type')
for pkg in xdata.xpath("//Package"):
if pkg.getparent().tag == 'Group':
grp = pkg.getparent().get('name')
if (type(grp) is not str and
grp.getparent().tag == 'Group'):
pgrp = grp.getparent().get('name')
else:
pgrp = 'none'
else:
grp = 'none'
pgrp = 'none'
ptuple = (pkg.get('name'), priority, ptype, grp, pgrp)
# check if package is already listed with same
# priority, type, grp
if ptuple in pset:
self.LintError(
"duplicate-package",
"Duplicate Package %s, priority:%s, type:%s" %
(pkg.get('name'), priority, ptype))
else:
pset.add(ptuple)
@classmethod
def Errors(cls):
return {"duplicate-packages": "error"}
|
